Pin interface-card links to the card foot; release v0.41.1 - #158
Merged
Merged
Conversation
0thernet
force-pushed
the
site/interface-card-link
branch
from
October 5, 2026 04:48
70b86b2 to
025dc4f
Compare
0thernet
enabled auto-merge (squash)
October 5, 2026 04:48
0thernet
force-pushed
the
site/interface-card-link
branch
from
October 5, 2026 04:51
025dc4f to
2eadc3f
Compare
- Add an optional `link` slot to `MarketingInterfaceGrid` entries so the shared component owns the docs/reference link: pinned to the foot of the equal-height card, end-aligned, and set in muted ink with a quiet underline. - Lay interface cards out as a flex column so `margin-block-start: auto` anchors the action row regardless of example height, and set card code at 0.78rem. - Slim proof-frame chrome padding and let `chrome="terminal"` and `chrome="window"` render without a `title`, drawing only the window lights so consumers can drop the generic "Terminal" label; browser chrome still requires a `url` or `title`. - Mirror the descendant rules across `product-marketing.css` and `product-marketing-foundation.css`, register the new atoms in the StyleX recipes, and cover the slot and titleless chrome in tests and the gallery fixture. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…tch samples The compiled link atoms now carry the same :focus-visible and forced-colors color variants as the standalone grammar, and the browser delivery assert prints a bounded mismatch sample so CI failures are diagnosable without local artifact access. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0thernet
force-pushed
the
site/interface-card-link
branch
from
October 5, 2026 05:24
757fa2e to
0767220
Compare
The generic p a quiet-link rule out-specified the interface link hook in the standalone and original-source grammars (text-underline-offset 0.2em versus the owned 0.18em), while compiled atoms won outright. Marking the anchor with data-hraness-marketing excludes it from the consumer prose grammar in every route; the owned rule now carries the dotted decoration explicitly so the visual result is unchanged. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkslot toMarketingInterfaceGridentries so the shared component owns the docs/reference link: pinned to the foot of the equal-height card, end-aligned, and set in muted ink with a quiet underline.margin-block-start: autoanchors the action row regardless of example height, and set card code at 0.78rem.chrome="terminal"andchrome="window"render without atitle, drawing only the window lights so consumers can drop the generic "Terminal" label; browser chrome still requires aurlortitle.product-marketing.cssandproduct-marketing-foundation.css, register the new atoms in the StyleX recipes, and cover the slot and titleless chrome in tests and the gallery fixture.v0.41.1with README notes and install pins (rebased overproduct-landscape.cssv0.41.0).Test plan
bun teston the two marketing suites: 57 pass, 0 fail.bun run lint,bun run typecheck,bun run build.bun run check:stylex-artifacts,bun run check:stylex-determinism(byte-identical across absolute roots).bun run checkvia required CI on this head (local browser lane was saturated by unrelated holders).Generated with Devin