Inset question rows and turn the marker into a rotating close glyph - #159
Merged
Merged
Conversation
0thernet
enabled auto-merge (squash)
October 5, 2026 04:54
0thernet
force-pushed
the
marketing-question-inset-motion
branch
from
October 5, 2026 05:07
2db3214 to
1d8601d
Compare
MarketingQuestionList rows read edge to edge and the open marker snapped to its rotated state. Inset the summary and answer content behind a tunable --hraness-marketing-question-inline-inset token, and give the plus marker a 240ms decelerating turn through 135 degrees so it settles as a close glyph. Reduced-motion preferences keep the instant state change. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0thernet
force-pushed
the
marketing-question-inset-motion
branch
from
October 5, 2026 05:13
1d8601d to
1b4c0bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarketingQuestionListrows inset their summary and answer content behind a new tunable--hraness-marketing-question-inline-insettoken (default 1.25rem), replacing the edge-to-edge text.+marker now transitions over 240ms through a 135-degree turn on open/close, settling as a close glyph instead of snapping.prefers-reduced-motionkeeps the instant state change; the same declarations ship in the standalone stylesheet and the compiled StyleX recipes.Test plan
bun run lintcleanbun run typecheckcleanbun run buildregeneratesdist/with the new atomsbun run check:stylex-artifactsandcheck:stylex-determinismpassbun test ./src— 508 tests passtest:browser) covered by the Required check on this PRGenerated with Devin