Skip to content

Routing view: a block's card, and finding its controls on the panel (t-143) - #116

Merged
JohnD-EE merged 3 commits into
mainfrom
feature/t143-routing-card
Oct 29, 2026
Merged

JohnD-EE merged 3 commits into
mainfrom
feature/t143-routing-card

Conversation

@JohnD-EE

Copy link
Copy Markdown
Contributor

What

  • Model D's routing blocks name the panel controls that set them. routingProblems now requires every control the sound hears to be in some block's controls.
  • Each block on the routing view opens a card: its designator and name, whether the patch uses it now, its description and specs, and the controls and jacks that set it.
    • Hovering or focusing a block shows the card. A click, tap, Enter or Space keeps it open and moves focus into it; pressing the block again puts it away.
  • Choosing a control or jack on the card finds it on the panel and flips the panel back through the page's flip. Focus goes to the Signal routing switch.

Review

  • /security-review: no findings. All changes are client-side and render static synth definitions.
  • /code-review: all 8 findings fixed in 9f7c758:
    • A new find now flips the panel with the animation; before, the panel snapped face up.
    • A second press of a block closes its kept card.
    • Keyboard focus moving to another block takes the card with it.
    • A focus-opened card is no longer lost when the mouse passes over another block.
    • Focus no longer drops to <body> after a find.
    • The card takes focus without scrolling the page.
    • Cleanups: a direct selector replaces the array scan, and the card item's duplicated markup is gone.

Checks

  • /pre-pr passed. Lint and format are clean on the changed files. The affected suites pass (192 tests).
  • The flip animation and the card's look are left for the owner's by-eye pass.

🤖 Generated with Claude Code

JohnD-EE and others added 3 commits October 29, 2026 20:33
Model D's blocks name their controls, and routingProblems holds every
heard control to a block so a card can say what drives it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… panel (t-143)

Hovering or focusing a block shows its card; a click, tap, Enter or
Space keeps it and moves focus in. Choosing a control or jack finds it
on the panel and flips back through the page's flip, so a control
already found still turns it over.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A find from a card now turns the panel over through the flip: the page
marks it seen, so its check no longer turns the view off first with no
transition. Focus goes to the Signal routing switch as the card goes.
A second press of a block puts its kept card away; keyboard focus moving
to another block takes the card there; a focus-opened card comes back
when the pointer leaves; and the card takes focus without scrolling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JohnD-EE
JohnD-EE merged commit b45ed4b into main Oct 29, 2026
19 checks passed
@JohnD-EE
JohnD-EE deleted the feature/t143-routing-card branch October 29, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant