Skip to content

Show the panel's own controls in a block's routing card (t-147) - #119

Merged
JohnD-EE merged 4 commits into
mainfrom
feature/t147-routing-card-crop
Oct 30, 2026
Merged

JohnD-EE merged 4 commits into
mainfrom
feature/t147-routing-card-crop

Conversation

@JohnD-EE

Copy link
Copy Markdown
Contributor

Summary

  • A block's routing card now shows a crop of the panel itself, with the block's controls and jacks lit in the module's colour (panelCrops in lib/app/synths/lib/routing.ts, rendered by RoutingCard).
  • One crop when the block's spots fit; otherwise up to CROP_MAX clusters, laid out left to right.
  • A fader is lit along its travel. A select is lit as the box round its row of buttons. A control the panel doesn't draw at the current values (isShown) isn't lit.
  • The crop is documented in .context/.

Review

  • /pre-pr and /security-review passed before review.
  • /code-review found four issues and three are fixed: hidden controls were lit, a select's lit circle was too big, and a jack check was dead code.
  • One is skipped: duplicate React keys only occur when the routing data lists a control twice, so routing validation should catch that, not the card.

Test plan

  • Type-check, plus ESLint and Prettier on the changed files
  • Routing and routing-card unit tests
  • Owner's visual check of the cards in the app (batched)

🤖 Generated with Claude Code

JohnD-EE and others added 4 commits October 30, 2026 11:37
The card draws a crop of the faceplate on the page through <use>, so it
is the panel at its current values, cables and design without a second
render. panelCrops() boxes the block's controls and jacks by their reach,
pads and keeps the box on the faceplate, and splits a block spread past
840 x 660 units into up to three clusters; past that, no picture.
controlReach moves from layers.tsx into patch.ts so the find spotlight
and the crop measure a control the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… lights its row (t-147)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JohnD-EE
JohnD-EE merged commit 3703c0f into main Oct 30, 2026
19 checks passed
@JohnD-EE
JohnD-EE deleted the feature/t147-routing-card-crop branch October 30, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant