Repository navigation
Light a modular's patched line and keyboard on the routing view (t-148) - #120
Merged
Merged
Conversation
…view (t-148) routingActivity() built the audio line from audio edges alone, and a 900-series routing has none, so a System 15, 35 or 55 stayed dark while it played. Live audio cables now join the line, and the CM1A follows the engine's gate, which is the key held. The 911s get no meter: the engine's env1/env2 are its own envelopes, not the 911 slots in moog-core.ts, so they glow from what triggers them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…low the sound (t-148) - The engine meters the 900 path's gate as the key held, not its own envelopes' trigger settings, so a drone no longer lights the CM1A. - On a modular, a live module that makes signal and has no meter (a 911, a modulating 921) follows the output's level, so an envelope stays lit through its release and a modulator no longer copies the key gate. - A live audio cable puts its blocks on the audio path only when it carries audio from a module that makes it, so a mixer or mult passing control stays off the line. - Live cables are filtered once per frame; the tests pick audio cables by signal and read the gate from whole renders rather than a meter index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the routing view, a modular (System 55 / the 900 series) now glows the way a fixed synth does: its patched audio line follows the output's level and its keyboard follows the key.
lib/app/synths/lib/routing-activity.ts).gatemeter. On the 900 path the engine now meters the gate as the key held, not as its own envelopes' trigger settings, which the 900 sound path doesn't use, so a drone or repeat no longer lights it (lib/app/synths/audio/dsp-core.ts).audioJacks(VCS3, Syntrx II and the 900), because without it every cable is control.Review
/pre-prand/security-reviewpassed./code-reviewraised 8 findings, all addressed in ff0e653:audioJacks, so their cables are all control and nothing changes for them. The pin-matrix synths are covered by the fix for 4.The new routing-activity tests fail against the old rule (3 of 21), and the drone case fails against the old engine meter.
Test plan
npx tsc --noEmitis clean.vitestoversynths/lib,synths/routinganddsp-core: 721 pass.🤖 Generated with Claude Code