Repository navigation
Replace Dim unused with the Signal control, and light the Model D's panel live (t-150) - #122
Merged
Merged
Conversation
…anel live (t-150) The top rail's Dim unused toggle becomes Signal, with a menu of Off / In use / Live. In use is Dim unused unchanged, kept with the account settings as before. Live draws the routing view's lamps on the panel's face, over each part's controls, and is kept in this browser only. That way Live adds nothing to the account's settings, its API or the data export. The meters-to-ActivityMeters step moves out of the routing view into a shared reader that both views use. Under reduced motion it raises every wave to FAST_HZ (steadyMeters), so the LFO and slow oscillators glow steady on both views. Live is offered on the Model D only; t-151 extends it to every routed synth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…(t-150) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Live where it was chosen (t-150) From the code review: the trigger's accessible name now carries the mode, the chevron has its own class so the rail's rule for hiding the close mark no longer hides it, Off clears Live so a dim synced back on opens In use, and In use on a synth without Live no longer clears the Model D's choice. kys.live moves below the account-stamped settings, beside the other browser-only keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The top rail's Dim unused toggle is now Signal, a menu with three modes:
Live is offered on the Model D only for now. t-151 extends it to every routed synth.
The step that turns meters into
ActivityMetersmoves out of the routing view into a shared reader (components/app/synth/live-meters.ts), so both views use it. Under reduced motion it raises every wave toFAST_HZ(steadyMeters), so the LFO and slow oscillators glow steady on both views.Why this shape
Live is kept in this browser only (
kys.live), not with the account settings. So Live adds nothing to the account's settings, its API or the data export. In use stays the existingdimsetting, so nobody's stored preference moves.Review round
The security review found nothing. Code-review fixes are in a separate commit:
Signal on the panel: Live). Before, it announced the same thing whatever the mode.dimback on, the panel opens In use, not Live. Choosing In use on a synth without Live no longer clears the Model D's Live.kys.livenow sits with the other browser-only keys, after the account-stamped settings.Findings I did not act on, deliberately:
LIVE_SYNTHSis a hard-coded set; t-151 removes it.Still open
The by-eye check of the Live glow on the panel is left for the owner's end-of-build pass.
🤖 Generated with Claude Code