Repository navigation
feat: opt-in basic auth, noindex and PHP memory limit for FrankenPHP - #49
Merged
Merged
Conversation
Add environment-driven, off-by-default features to the frankenphp-trixie variant: basic auth (password hashed by a new docker-drupal-entrypoint, failing closed when credentials are missing), noindex headers and robots.txt via snippets, and PHP_MEMORY_LIMIT for the web server. Includes README docs and CI tests on both architectures.
Contributor
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43
Adds three opt-in, environment-driven features to the frankenphp-trixie variant (all off or unchanged by default):
docker-drupal-entrypointhashes the password withfrankenphp hash-password(stdin), fails closed when basic auth is requested without credentials, unsets the plaintext, then execsdocker-php-entrypoint.The optional NOINDEX=true switch is intentionally not implemented; the snippet variable is enough.
Tests: new CI steps for the FrankenPHP variant on both arches (defaults unchanged, opt-in run, fail-closed) via tests/verify-frankenphp-optin.sh. README documents the variables, the fail-closed rule and the note for downstream entrypoints.