Make bare attach and detach target all clients - #560
Open
platypii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hyp attachtarget every active registered client adapterhyp detachtarget every known client descriptorVerification
node --test test/core/command-dispatch.test.js test/core/integration.test.js test/core/client-name-case-insensitive.test.js(51 tests)npm run smoke -- client_attach_idempotentgit diff --checknpm testpasses 3,279 tests and fails two unrelated tests inblob-store.test.jsandusage-policy-fold.test.js; both reproduce in isolation and neither file is changed herenpm run typecheckreports thatsanitizeLabelis not exported fromhypaware/core/utilin untouchedai-gateway/src/entrypoint_activity.jsnpm run smoke -- claude_attach_detachrecords a successful attach, then fails its existing hook-shape assertion because both session-context and classify-cwd hooks are present