T10: finish deferred rewrite of openclaw-client-registration.test.js - #567
Merged
philcunliffe merged 1 commit intoAug 1, 2026
Conversation
T4 and T5 already retargeted the two attach() no-op tests and the descriptor's attach_probe assertion to keep the suite green while they landed; this closes the two pieces both left for T10: - The "honest no-op" detach test's comment still credited the retired R7 no-attach_probe guard. Since T5 restored the manifest's json_path attach_probe, the no-op this test actually observes on a fresh temp HOME is detachClientFromDisk's absent-settings-file guard instead. Corrected the comment to say so. - Added a companion case that stages a real openclaw.json via the actual createOpenclawAttach() effect, then drives the same hyp detach CLI entry point (buildClientDescriptorMap's real manifest descriptor -> detachClientFromDisk's json_path branch) and asserts the ownership-based detachJsonPathProviders (T2) actually fires: changed:true, the removed baseUrl, and both provider entries gone from the file while everything else in it is untouched. Task-Id: T10
philcunliffe
merged commit Aug 1, 2026
d178d5a
into
integration/openclaw-two-lane-capture
5 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements task T10 of openclaw-two-lane-capture.
T4 and T5 already retargeted most of test/plugins/openclaw-client-registration.test.js while landing (attach() write tests, the json_path attach_probe descriptor shape), explicitly deferring the rest to T10. This closes what remained:
The registration-order test and the generic hyp attach resolution test were left unchanged per the task description.
Test plan
npm test(3319 passed, 1 pre-existing skip)node --test test/plugins/openclaw-client-registration.test.js(8/8 pass)npm run typecheck- one pre-existing failure in hypaware-core/plugins-workspace/openclaw/src/backfill.js:192 (sweep_crononJsonValue), unrelated to this change and present before it (verified viagit stash); out of T10's scope (test/plugins/openclaw-client-registration.test.js only)Task-Id: T10