Repository navigation
fix: read the secret marker as x-scalo-secret - #768
Draft
catinspace-au wants to merge 1 commit into
Draft
catinspace-au wants to merge 1 commit into
catinspace-au wants to merge 1 commit into
Conversation
scalo now marks a secret config field with x-scalo-secret alone, so the contract reader keys on that one name and no longer reads x-dfe-secret. SECRET_MARKERS becomes SECRET_MARKER. The app schema fixtures under tests/fixtures/contract, contract-main and contract-acknowledgements carry the marker under its new name, the name each app emits once it is rebuilt on that scalo. A new test checks every field an app marks reads as a secret, and fails if the fixtures carry a marker the reader does not key on. This must merge together with the 2.2.1 fleet rebuild. An app image built on an older scalo marks secrets only as x-dfe-secret, and this reader would no longer see those marks.
This was referenced Oct 8, 2026
catinspace-au
marked this pull request as draft
October 8, 2026 04:20
Contributor
Author
|
Back to draft on purpose: this merges in the same window as the 2.2.1 fleet rebuild, because the engine reads x-scalo-secret only once the rebuilt apps emit it. Green at e186746. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MERGE THIS TOGETHER WITH THE 2.2.1 FLEET REBUILD, not before. An app image built on an older scalo marks its secrets only as
x-dfe-secret, and after this the engine no longer sees those marks. Fields whose names say they are credentials stay masked by the name rules either way, but a marked field with a plain name would not.scalo marks a secret config field with
x-scalo-secretalone now (hyperi-io/scalo-rs#293, hyperi-io/scalo-py#86). The engine reads that one name.contract.py:SECRET_MARKERSbecomesSECRET_MARKER = "x-scalo-secret", and_marked_secretkeys on it. No dual read.source.jsonrefs still name the app commits the fixtures came from, so refresh them from the rebuilt apps when the fleet lands.Done when the engine treats every
x-scalo-secretfield in the app fixtures as a secret, CI is green, and the rebuilt fleet merges alongside.Checks:
hyperi-ci check --quickpassed. The five test files that read the marker or the fixtures pass, 557 tests. The full suite was not run locally, to keep inside the /tmp inode limit.