Repository navigation
docs: match the design doc to the chart paths and values - #108
Merged
Merged
Conversation
The chart has no emptyDir for /var/run/vector/config. The image creates that directory, so the volumes diagram now says so. Section 5.1 pointed at /etc/dfe/config.yaml and /etc/dfe/transforms. Both now use /etc/dfe-transform-vector, as the chart and image do. Section 9.2 now shows the abridged shape of chart/values.yaml, in place of a values layout the chart no longer has. It also says the chart has no transforms value.
|
Released in v1.0.46 -- https://github.com/hyperi-io/dfe-transform-vector/releases/tag/v1.0.46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/DESIGN.md still described a chart and image layout that no longer exists, and this repo is going public.
Done when every path and value named in those spots matches chart/ and the Dockerfile.