Repository navigation
fix: set the OCI title and description on the transform-vector deployment contract - #111
Merged
Merged
Conversation
…ment contract scalo leaves oci_labels.title and oci_labels.description empty unless the app sets them, so the published contract.json and the image metadata carried neither. Set the title to dfe-transform-vector and the description to the chart description, as dfe-loader does, and pin both with a unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published contract.json had oci_labels.title and oci_labels.description blank, so the image and the GHCR package page showed neither. scalo leaves both empty unless the app sets them, so they are now set to dfe-transform-vector and the chart description, same as dfe-loader. One constant feeds both descriptions so they cannot drift. A unit test pins it.
Done when the emitted contract carries a non-empty oci_labels.title and oci_labels.description.