fix(http1): discard content-length header when received before transfer-encoding#4124
Open
seanmonstar wants to merge 1 commit into
Open
fix(http1): discard content-length header when received before transfer-encoding#4124seanmonstar wants to merge 1 commit into
seanmonstar wants to merge 1 commit into
Conversation
…er-encoding While hyper currently recognizes the correct message payload semantics when both content-length and transfer-encoding headers are sent, there are cases where it doesn't always strip the canceled content-length header. This fix now correctly removes the header if it was seen before transfer-encoding. It also now sets the connection to close at the end of the message, as recommended in the new RFC 9112. (To be clear, the semantics have always been correct. This reduces the possibility of forwarding confusing headers to a remote that doesn't know how to act correctly.) Closes #4123
cratelyn
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While hyper currently recognizes the correct message payload semantics when both content-length and transfer-encoding headers are sent, there are cases where it doesn't always strip the canceled content-length header.
This fix now correctly removes the header if it was seen before transfer-encoding.
It also now sets the connection to close at the end of the message, as recommended in the new RFC 9112.
(To be clear, the semantics have always been correct. This reduces the possibility of forwarding confusing headers to a remote that doesn't know how to act correctly.)
Thanks @bardiharborow
Closes #4123