Skip to content

make sure nightly job failure adds release blocker label#1606

Open
simongdavies wants to merge 2 commits into
hyperlight-dev:mainfrom
simongdavies:nightly-failure-should-add-blocker-issue
Open

make sure nightly job failure adds release blocker label#1606
simongdavies wants to merge 2 commits into
hyperlight-dev:mainfrom
simongdavies:nightly-failure-should-add-blocker-issue

Conversation

@simongdavies

Copy link
Copy Markdown
Member

fixes #1526

Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 1, 2026 12:21
@simongdavies simongdavies added the kind/bugfix For PRs that fix bugs label Jul 1, 2026
@simongdavies simongdavies added the ready-for-review PR is ready for (re-)review label Jul 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rust nightly workflow’s CI-failure notifier configuration so nightly musl failures de-duplicate into their own issue (rather than reusing the general periodic-CI issue), with the goal of ensuring the resulting failure issue is created with the release-blocker label.

Changes:

  • Switch the notifier’s first label (used as the de-duplication/search key) from area/ci-periodics to area/ci-periodics-nightly in the nightly musl failure job.

Comment thread .github/workflows/RustNightly.yml Outdated

@ludfjig ludfjig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix it?

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
@simongdavies

Copy link
Copy Markdown
Member Author

How does this fix it?

The script that runs creates an issue if it cannot find an open issue with the first label passed as an argument, both this job and the coverage job share a first label, the coverage job does not apply the release-blocker label, so if the coverage job fails it creates an issue WITHOUT the release-blocker label, then this job fails finds the issue and adds to it, but doesn't add the label.

I guess we could change the script but this PR gives a unique label to this job so the issue will always have the release-blocker label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs ready-for-review PR is ready for (re-)review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#1522 did not get release-blocker label

3 participants