Repository navigation
tree-widget: Bump peer deps - #1843
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The presentation-components major upgrade and raised peer minimums need build and integration compatibility confirmation before approval.
No open issues 🎉
3 files not reviewed
apps/performance-tests/pnpm-lock.yaml: Generated filepackages/test-utilities/pnpm-lock.yaml: Generated filepackages/tree-widget/pnpm-lock.yaml: Generated file
What changed in this PR
Updates tree-widget dependency requirements and aligns supporting applications and test utilities with newer iTwin releases.
Changes:
- Raises peer minimums to iTwin Core 5.14, AppUI 5.35, and presentation-components 6.
- Updates development and application dependencies, with refreshed test-utilities and performance-test lockfiles.
- Exempts presentation-components 6.0.1 from the minimum release-age restriction.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds the release-age exception for presentation-components 6.0.1. |
| packages/tree-widget/package.json | Raises peer minimums and updates development dependencies. |
| packages/test-utilities/pnpm-lock.yaml | Refreshes resolved iTwin and transitive dependencies. |
| packages/test-utilities/package.json | Updates development dependencies to iTwin Core 5.14.3. |
| apps/test-viewer/package.json | Aligns viewer dependencies with the updated tree-widget requirements. |
| apps/performance-tests/pnpm-lock.yaml | Refreshes dependency resolutions and workspace peer metadata. |
| apps/performance-tests/package.json | Updates performance-test dependencies to iTwin Core 5.14.3. |
| apps/learning-snippets/package.json | Aligns example dependencies with the newer Core, AppUI, and presentation releases. |
Review effort: Balanced
There was a problem hiding this comment.
Tree-Widget Next benchmark
| Benchmark suite | Current: bd91809 | Previous: 5c2dc19 | Deviation | Status |
|---|---|---|---|---|
models tree 50k 3D elements search > get search paths |
529 ms |
824 ms |
-35.80% |
✅ |
models tree 50k 3D elements search > get search paths (P95 of main thread blocks) |
38 ms |
53 ms |
-28.30% |
〰️ |
models tree 50k 3D elements search > load hierarchy from search paths |
71070 ms |
86677 ms |
-18.01% |
✅ |
models tree 50k 3D elements search > load hierarchy from search paths (P95 of main thread blocks) |
24 ms |
40 ms |
-40% |
〰️ |
models tree 50k categories > collect nodes |
1528 ms |
2520 ms |
-39.37% |
✅ |
models tree 50k categories > collect nodes (P95 of main thread blocks) |
60 ms |
88 ms |
-31.82% |
〰️ |
models tree 50k categories > validate initial visibility |
1641 ms |
2638 ms |
-37.79% |
✅ |
models tree 50k categories > validate initial visibility (P95 of main thread blocks) |
129 ms |
156 ms |
-17.31% |
〰️ |
models tree 50k categories > change visibility |
129 ms |
214 ms |
-39.72% |
✅ |
models tree 50k categories > change visibility (P95 of main thread blocks) |
52 ms |
58 ms |
-10.34% |
〰️ |
models tree 50k categories > validate changed visibility |
1718 ms |
2618 ms |
-34.38% |
✅ |
models tree 50k categories > validate changed visibility (P95 of main thread blocks) |
0 ms |
24 ms |
-100% |
〰️ |
models tree 50k 3D elements > collect nodes |
26935 ms |
34374 ms |
-21.64% |
✅ |
models tree 50k 3D elements > collect nodes (P95 of main thread blocks) |
29 ms |
71 ms |
-59.15% |
〰️ |
models tree 50k 3D elements > validate initial visibility |
1272 ms |
1499 ms |
-15.14% |
✅ |
models tree 50k 3D elements > validate initial visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D elements > change model visibility |
63 ms |
111 ms |
-43.24% |
〰️ |
models tree 50k 3D elements > change model visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D elements > validate changed model visibility |
1731 ms |
2284 ms |
-24.21% |
✅ |
models tree 50k 3D elements > validate changed model visibility (P95 of main thread blocks) |
0 ms |
33 ms |
-100% |
〰️ |
models tree 50k 3D elements > change category node visibility |
343 ms |
463 ms |
-25.92% |
✅ |
models tree 50k 3D elements > change category node visibility (P95 of main thread blocks) |
34 ms |
55 ms |
-38.18% |
〰️ |
models tree 50k 3D elements > validate changed category visibility |
1216 ms |
1631 ms |
-25.44% |
✅ |
models tree 50k 3D elements > validate changed category visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D elements > validate per-model category override |
1262 ms |
1552 ms |
-18.69% |
✅ |
models tree 50k 3D elements > validate per-model category override (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D elements > change element visibility |
39 ms |
40 ms |
-2.50% |
〰️ |
models tree 50k 3D elements > change element visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D elements > validate changed element visibility |
1631 ms |
2276 ms |
-28.34% |
✅ |
models tree 50k 3D elements > validate changed element visibility (P95 of main thread blocks) |
31 ms |
66 ms |
-53.03% |
〰️ |
models tree 50k 3D child elements with different categories > collect nodes |
32216 ms |
43878 ms |
-26.58% |
✅ |
models tree 50k 3D child elements with different categories > collect nodes (P95 of main thread blocks) |
42 ms |
76 ms |
-44.74% |
〰️ |
models tree 50k 3D child elements with different categories > validate initial visibility |
1448 ms |
2234 ms |
-35.18% |
✅ |
models tree 50k 3D child elements with different categories > validate initial visibility (P95 of main thread blocks) |
0 ms |
22 ms |
-100% |
〰️ |
models tree 50k 3D child elements with different categories > change visibility |
44 ms |
51 ms |
-13.73% |
〰️ |
models tree 50k 3D child elements with different categories > change visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D child elements with different categories > validate changed visibility |
4113 ms |
5657 ms |
-27.29% |
✅ |
models tree 50k 3D child elements with different categories > validate changed visibility (P95 of main thread blocks) |
47 ms |
57 ms |
-17.54% |
〰️ |
models tree 50k 3D child elements with different categories and excluded classes > collect nodes |
32714 ms |
44199 ms |
-25.98% |
✅ |
models tree 50k 3D child elements with different categories and excluded classes > collect nodes (P95 of main thread blocks) |
33 ms |
66 ms |
-50% |
〰️ |
models tree 50k 3D child elements with different categories and excluded classes > validate initial visibility |
2080 ms |
2629 ms |
-20.88% |
✅ |
models tree 50k 3D child elements with different categories and excluded classes > validate initial visibility (P95 of main thread blocks) |
50 ms |
129 ms |
-61.24% |
✅ |
models tree 50k 3D child elements with different categories and excluded classes > change visibility |
44 ms |
52 ms |
-15.38% |
〰️ |
models tree 50k 3D child elements with different categories and excluded classes > change visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree 50k 3D child elements with different categories and excluded classes > validate changed visibility |
5993 ms |
7089 ms |
-15.46% |
✅ |
models tree 50k 3D child elements with different categories and excluded classes > validate changed visibility (P95 of main thread blocks) |
59 ms |
96 ms |
-38.54% |
〰️ |
categories tree 50k subCategories search > get search paths |
685 ms |
947 ms |
-27.67% |
✅ |
categories tree 50k subCategories search > get search paths (P95 of main thread blocks) |
48 ms |
77 ms |
-37.66% |
〰️ |
categories tree 50k subCategories search > load hierarchy from search paths |
3506 ms |
5768 ms |
-39.22% |
✅ |
categories tree 50k subCategories search > load hierarchy from search paths (P95 of main thread blocks) |
33 ms |
60 ms |
-45% |
〰️ |
categories tree 50k subCategories > collect nodes |
3682 ms |
5540 ms |
-33.54% |
✅ |
categories tree 50k subCategories > collect nodes (P95 of main thread blocks) |
37 ms |
42 ms |
-11.90% |
〰️ |
categories tree 50k subCategories > validate initial visibility |
1153 ms |
1188 ms |
-2.95% |
〰️ |
categories tree 50k subCategories > validate initial visibility (P95 of main thread blocks) |
0 ms |
28 ms |
-100% |
〰️ |
categories tree 50k subCategories > change visibility |
338 ms |
359 ms |
-5.85% |
〰️ |
categories tree 50k subCategories > change visibility (P95 of main thread blocks) |
0 ms |
25 ms |
-100% |
〰️ |
categories tree 50k subCategories > validate changed visibility |
1049 ms |
1097 ms |
-4.38% |
〰️ |
categories tree 50k subCategories > validate changed visibility (P95 of main thread blocks) |
0 ms |
28 ms |
-100% |
〰️ |
categories tree 50k categories > collect nodes |
77811 ms |
89715 ms |
-13.27% |
✅ |
categories tree 50k categories > collect nodes (P95 of main thread blocks) |
30 ms |
46 ms |
-34.78% |
〰️ |
categories tree 50k categories > validate initial visibility |
4956 ms |
6206 ms |
-20.14% |
✅ |
categories tree 50k categories > validate initial visibility (P95 of main thread blocks) |
88 ms |
77 ms |
14.29% |
〰️ |
categories tree 50k categories > change visibility |
694 ms |
796 ms |
-12.81% |
✅ |
categories tree 50k categories > change visibility (P95 of main thread blocks) |
48 ms |
50 ms |
-4% |
〰️ |
categories tree 50k categories > validate changed visibility |
4542 ms |
5787 ms |
-21.51% |
✅ |
categories tree 50k categories > validate changed visibility (P95 of main thread blocks) |
35 ms |
32 ms |
9.38% |
〰️ |
categories tree 50k categories and excluded classes > collect nodes |
76741 ms |
90622 ms |
-15.32% |
✅ |
categories tree 50k categories and excluded classes > collect nodes (P95 of main thread blocks) |
36 ms |
147 ms |
-75.51% |
✅ |
categories tree 50k categories and excluded classes > validate initial visibility |
5301 ms |
7345 ms |
-27.83% |
✅ |
categories tree 50k categories and excluded classes > validate initial visibility (P95 of main thread blocks) |
130 ms |
149 ms |
-12.75% |
〰️ |
categories tree 50k categories and excluded classes > change visibility |
672 ms |
812 ms |
-17.24% |
✅ |
categories tree 50k categories and excluded classes > change visibility (P95 of main thread blocks) |
49 ms |
67 ms |
-26.87% |
〰️ |
categories tree 50k categories and excluded classes > validate changed visibility |
6461 ms |
8118 ms |
-20.41% |
✅ |
categories tree 50k categories and excluded classes > validate changed visibility (P95 of main thread blocks) |
25 ms |
30 ms |
-16.67% |
〰️ |
classifications tree 50k classifications search > get search paths |
1510 ms |
2302 ms |
-34.40% |
✅ |
classifications tree 50k classifications search > get search paths (P95 of main thread blocks) |
143 ms |
196 ms |
-27.04% |
✅ |
classifications tree 50k classifications search > load hierarchy from search paths |
37457 ms |
46846 ms |
-20.04% |
✅ |
classifications tree 50k classifications search > load hierarchy from search paths (P95 of main thread blocks) |
0 ms |
22 ms |
-100% |
〰️ |
classifications tree 50k classifications > collect nodes |
8810 ms |
17020 ms |
-48.24% |
✅ |
classifications tree 50k classifications > collect nodes (P95 of main thread blocks) |
28 ms |
40 ms |
-30% |
〰️ |
classifications tree 50k classifications > validate initial visibility |
5671 ms |
10861 ms |
-47.79% |
✅ |
classifications tree 50k classifications > validate initial visibility (P95 of main thread blocks) |
3518 ms |
7867 ms |
-55.28% |
✅ |
classifications tree 50k classifications > change visibility |
116 ms |
172 ms |
-32.56% |
✅ |
classifications tree 50k classifications > change visibility (P95 of main thread blocks) |
0 ms |
24 ms |
-100% |
〰️ |
classifications tree 50k classifications > validate changed visibility |
2535 ms |
3606 ms |
-29.70% |
✅ |
classifications tree 50k classifications > validate changed visibility (P95 of main thread blocks) |
58 ms |
62 ms |
-6.45% |
〰️ |
classifications tree 50k classifications and excluded classes > collect nodes |
9614 ms |
18000 ms |
-46.59% |
✅ |
classifications tree 50k classifications and excluded classes > collect nodes (P95 of main thread blocks) |
22 ms |
42 ms |
-47.62% |
〰️ |
classifications tree 50k classifications and excluded classes > validate initial visibility |
5191 ms |
12669 ms |
-59.03% |
✅ |
classifications tree 50k classifications and excluded classes > validate initial visibility (P95 of main thread blocks) |
2775 ms |
9993 ms |
-72.23% |
✅ |
classifications tree 50k classifications and excluded classes > change visibility |
109 ms |
154 ms |
-29.22% |
〰️ |
classifications tree 50k classifications and excluded classes > change visibility (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
classifications tree 50k classifications and excluded classes > validate changed visibility |
2451 ms |
3525 ms |
-30.47% |
✅ |
classifications tree 50k classifications and excluded classes > validate changed visibility (P95 of main thread blocks) |
46 ms |
91 ms |
-49.45% |
〰️ |
This comment was automatically generated by workflow using github-action-benchmark.
Member
Author
This should be covered by #1795. Just need to update version numbers after merge |
grigasp
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.