IBX-12237: Passed Search extraClasses to InputTextInput wrapper instead of the input - #2002
Open
tischsoic wants to merge 1 commit into
Open
IBX-12237: Passed Search extraClasses to InputTextInput wrapper instead of the input#2002tischsoic wants to merge 1 commit into
tischsoic wants to merge 1 commit into
Conversation
albozek
approved these changes
Aug 11, 2026
alekmick
approved these changes
Aug 11, 2026
…ad of the input Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tischsoic
force-pushed
the
IBX-12237-image-library-search
branch
from
August 12, 2026 07:43
c30b0d4 to
d6c14b8
Compare
|
dew326
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related PRs:
Description:
The shared
Searchcomponent (common/input/filter.search.js) routed itsextraClassesprop throughextraAria.className, which lands on the raw<input>and — due to spread order in the DSBaseInput— replaced theids-input*classes entirely. With the defaultextraClasses = ''(the Image library case) the input rendered as<input class="">, i.e. completely unstyled.extraClassesis now passed toInputTextInput'sclassNameprop (the.ids-input-textwrapper), matching the established pattern intop.menu.search.input.js.Consumers checked: image-picker passes no
extraClasses; segmentation passesc-segments__sidebar-filter, which has no SCSS/JS references anywhere in that package, so moving the class from the input to the wrapper changes nothing visually.For QA:
Documentation: