Added doc for SiteAccessStamp - #3340
Open
mnocon wants to merge 6 commits into
Open
Conversation
* Described stamps for Ibexa Messenger * Fixed typos * Link to Symfony messages
Preview of modified filesPreview of modified Markdown: |
mnocon
marked this pull request as ready for review
August 4, 2026 14:05
Steveb-p
approved these changes
Aug 11, 2026
|
|
||
| The stamp changes the configuration scope only. | ||
| It doesn't change the SiteAccess in the `Ibexa\Core\MVC\Symfony\SiteAccess\SiteAccessServiceInterface` service. | ||
| `SiteAccessServiceInterface::getCurrent()` always returns the SiteAccess that the worker process started with, for all messages. |
Contributor
There was a problem hiding this comment.
Side note: Will be fixed in ibexa/core#798 / 6.0.
We could also make SiteAccessService to listen to CONFIG_SCOPE_CHANGE events in 5.x and react accordingly, and backport the stack feature from 6.0. In theory this is a bug (SiteAccessService::getCurrent() returning wrong site access), so we would not exactly break BC promise - but initially I thought we shouldn't.
@konradoboza @alongosz @ibexa/php-dev ?
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
code_samples/ change report
|
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
August 11, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for ibexa/messenger#13
Turns out we didn't have the "send the message to the transport" covered - adding this as well.
One TODO left: add the missing link once PHP API reference is regenerated