Repository navigation
fix(chat): fill the whole tab with the sticker panel switcher highlight - #283
Conversation
The selected Emoji / Stickers / GIF segment only tinted the area around its icon and label, and in light mode the white fill vanished on the white track. The highlight now fills its entire third of the switcher as a brand tint over the track (14% in light, 28% in dark), unselected segments stay clear, and a change fades the tint itself.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09f57e6f0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // segments have no colour at all, so a change fades the tint | ||
| // itself instead of passing through grey on the way to | ||
| // transparent black. | ||
| child: AnimatedContainer( |
There was a problem hiding this comment.
The supplied commit checklist explicitly leaves relevant tests unchecked because flutter test could not run, and provides no passing Quality result for this revision. Existing coverage in test/widget_test.dart exercises this media switcher, so tests are applicable; the simulator screenshots and combined-tree analysis do not complete that check. Record passing test results for the reviewed revision and complete the checklist before approval. AGENTS.md explicitly requires reviewers to request changes when applicable checks remain unchecked or supporting evidence is insufficient.
AGENTS.md reference: AGENTS.md:L19-L20
Useful? React with 👍 / 👎.
Automated PR reviewHead: Review unavailable: Incomplete model answer (length); manual review required. Remaining gates
No PR code runs with the model key or write token. Free-only routing; provider/rate-limit failures never authorize a merge. Existing review findings must be resolved, not hidden by a new recommendation. |
Change
The selected segment of the Emoji / Stickers / GIF switcher above the sticker panel only covered the icon and label. In light mode its white fill vanished on the white track.
Affected platforms: all (shared composer UI).
Related PRs and canonical PR (or
None; existing PRs checked): this is the canonical PR for this change. Open and recently closed PRs were checked; none covers it. It ships alongside #281, #282 and #284, which are independent fixes from the same request. Each touches different code and is useful alone.Telegram API Terms classification
Follow the contribution and agentic review rules. Select exactly one classification and explain it below.
This is an agentic source-code review classification. Every store version must remain compliant with applicable Telegram API Terms; the guarded-source exception does not apply to store distribution or review.
allowTelegramTosViolations(I_DONT_FUCKING_CARE_ABOUT_TOS), disabled in official builds, and available only in an explicitly enabled self-build.Reason and affected Telegram behavior:
Visual styling of an existing switcher; no Telegram API usage or behavior changes.
Basic checks (every PR)
Check each item after verification. If a check is inapplicable, explain why in the evidence below before checking it.
dart format --output=none --set-exit-if-changed lib test integration_test test_driver.flutter analyze.flutter test --concurrency=4.Commands, results, platform/build/UI evidence, and reasons for inapplicable checks:
dart format --output=none --set-exit-if-changed lib test integration_test test_driverwith the Dart 3.12.2 SDK from Flutter 3.44.2: 0 changed.dart analyze --fatal-infos(the same analysis server and rulesflutter analyzeuses, Flutter 3.44.2 SDK): No issues found on this branch alone and on all four PRs combined.flutter testcould not run in the authoring sandbox (Alpine/musl host), so the tests box stays unchecked until Quality CI reports on this PR head. No new tests were added, at the maintainer's request.I_DONT_FUCKING_CARE_ABOUT_TOS=false). Together the four branches match the tested source, apart from two lint-only edits in fix(ios): start opened iPhone Duo panes beside the status cluster #281.Section 1.4 exception checks
Not applicable: compliant change, no guarded behavior.
--dart-define=I_DONT_FUCKING_CARE_ABOUT_TOS=false, the feature is absent and ordinary Telegram behavior remains intact.--dart-define=I_DONT_FUCKING_CARE_ABOUT_TOS=true, the feature works through the guarded entry points in a self-build; I included relevant test and build/UI evidence.falseand have no option that enables it. All store versions remain compliant with applicable Telegram API Terms.Guard locations and evidence for each flag variant: Not applicable.
Agentic reviewer confirmation
Agentic code reviewer only: record this confirmation in the PR review or check these boxes before approval.