Repository navigation
feat(enhancements): ended Forge sandboxes read as grey Terminated - #6
Merged
Merged
Conversation
Replacing an element's children dropped its icon and swapped out nodes a framework-rendered page keeps references to. Rewrite the element's own text nodes in place instead, and skip elements whose text is nested deeper. Refs #5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Relabels the status pill from Completed to Terminated and greys it with Forge's own neutral pill variables, replacing the checkmark with a neutral ring. Targets data- attributes only; Forge's classes are hashed. Tested against a hand-written synthetic fixture; numbered zero UUIDs are now accepted as placeholders. Refs #5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…entre the badge Forge raises its pill colour rules' specificity by repeating the class, so the plain override never won and the pill stayed green. The colour overrides are now !important (they exist only while the enhancement is on). The checkmark becomes a grey ring with a diagonal bar, drawn as a mask at the original icon's size. The Enhanced badge moves to the top centre. Refs #5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A ring with a horizontal dash (as on the European no-entry sign) reads as ended rather than as an error, which the diagonal bar suggested. Refs #5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The first real enhancement: in the Forge sandboxes list, an ended sandbox's green Completed pill becomes a neutral grey Terminated, so an ended sandbox no longer reads as running. Rationale and the natural-exit caveat are in #5.
Changes
enhancements/forge-sandbox-status.js— relabel + CSS reusing the pill's own--tag-*variables with Forge's neutral values (with fallbacks); checkmark replaced by a neutral ring. Targetsdata-attributes only.createRelabelnow rewrites the element's own text nodes in place instead of replacing its children — icons survive, and so do nodes a framework-rendered page holds references to.Testing
npm run lint,npm test— 43 tests, including exact restore, idempotence, and other statuses left alonetest/fixtures/private/, not committed): both Completed pills relabelled, icons kept, exact restoreRelated Issues
Closes #5
🤖 Generated with Claude Code