Repository navigation
[Vulcan] Correct print repeat coordinate parameter documentation - #333
Merged
Merged
Conversation
Owner
Author
|
Final validation for head
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct four PHPDoc parameter types for
ExcelSheet::setPrintRepeatRows()andsetPrintRepeatCols()toint. The column start was misleadingly documented asbool, and the remaining coordinates asmixed. Existing public signatures and nativellparsing already require integer coordinates. Runtime code, signatures and coverage are unchanged.Validation
-Wall -Wextra -Wno-unused-parameter -Wimplicit-fallthrough -Werror, zero diagnostics.git merge-tree --write-treeagainst default and all own open siblings ([Vulcan] Clarify workbook text encoding #330, [Vulcan] Correct clearing method return documentation #331, [Vulcan] Clarify XLS palette support in colorUnpack documentation #332), whose changed files are disjoint.Limitations
Local PHP 8.4.26 NTS / LibXL 5.2.0.1 trial / Linux; reused existing configure header, not a fresh phpize/configure run. Licensed, ZTS and Windows cases account for skips. No local cross-version, Windows or performance claim. Exact-head remote CI is checked separately. No runtime release note needed for this API-reference-only correction; released changelog entries are untouched.