Skip to content

[Vulcan] Correct print repeat coordinate parameter documentation - #333

Merged
iliaal merged 1 commit into
masterfrom
docs/print-repeat-coordinate-types
Oct 21, 2026
Merged

iliaal merged 1 commit into
masterfrom
docs/print-repeat-coordinate-types

Conversation

@iliaal

@iliaal iliaal commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Summary

Correct four PHPDoc parameter types for ExcelSheet::setPrintRepeatRows() and setPrintRepeatCols() to int. The column start was misleadingly documented as bool, and the remaining coordinates as mixed. Existing public signatures and native ll parsing already require integer coordinates. Runtime code, signatures and coverage are unchanged.

Validation

  • All 300 current-default blobs verified before editing. Exactly four PHPDoc lines change; non-comment PHP tokens are identical.
  • Independent review confirms native range parsing, stubs, and existing PHPTs 059, 087 and 146 support these types.
  • Documentation-contract check passes on final file and fails on the restored baseline.
  • Fresh strict native compilation: -Wall -Wextra -Wno-unused-parameter -Wimplicit-fallthrough -Werror, zero diagnostics.
  • Full existing PHPT suite on final snapshot: 254 passed, 7 skipped, 0 failed, 0 warned. All 12 API-reference files lint clean; whitespace check passes.
  • Clean git merge-tree --write-tree against default and all own open siblings ([Vulcan] Clarify workbook text encoding #330, [Vulcan] Correct clearing method return documentation #331, [Vulcan] Clarify XLS palette support in colorUnpack documentation #332), whose changed files are disjoint.

Limitations

Local PHP 8.4.26 NTS / LibXL 5.2.0.1 trial / Linux; reused existing configure header, not a fresh phpize/configure run. Licensed, ZTS and Windows cases account for skips. No local cross-version, Windows or performance claim. Exact-head remote CI is checked separately. No runtime release note needed for this API-reference-only correction; released changelog entries are untouched.

iliaal commented Oct 21, 2026

Copy link
Copy Markdown
Owner Author

Final validation for head 2f295f92df9db83022d755ed8517d49211362339:

  • Tests: all 15 jobs passed, including PHP 8.1–8.6, LibXL versions, ZTS, ASAN, stub freshness and PIE.
  • Windows Build: all 21 executed jobs passed; release-only attachment skipped. One PHP 8.3 x86 NTS packaging download encountered an upstream HTTP 504 after its 246 tests passed; failed-job retry succeeded on unchanged code.
  • All executed job logs inspected; zero PHPT failures. Skips vary by platform/version/license and are not passes.
  • Exact remote tree matches the four-line documentation correction, PR is non-draft and conflict-free. Local validation and limitations remain as documented in the PR body.

@iliaal
iliaal merged commit 51e4b6d into master Oct 21, 2026
58 of 59 checks passed
@iliaal
iliaal deleted the docs/print-repeat-coordinate-types branch October 21, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant