Repository navigation
[Vulcan] Clarify write-only border setter behavior - #334
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
borderStyle()andborderColor()enter getter mode with omitted/null arguments.Validation
-Wall -Wextra -Wno-unused-parameter -Wimplicit-fallthrough -Werror, zero diagnostics.git diff --check, independent review, and merge-tree check passed. No open sibling PRs at publication.Limits
Local validation used PHP 8.4.26 NTS and LibXL 5.2.0.1 trial on Linux with retained configure headers; no fresh phpize/configure, sanitizer, cross-platform or performance measurements. Seven existing environment/license skips are not passes. Exact-head GitHub Actions completed successfully: all 36 executed jobs passed across Tests and Windows Build. All executed job logs were inspected, with zero PHPT failures; the release-only attachment job was skipped, not counted as a pass.