Repository navigation
[Vulcan] Document the complete indexed named range result - #335
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namestring inExcelSheet::getIndexRange()'s seven-key return array.falseresult when no range exists.Validation
-Wall -Wextra -Werror -Wstrict-prototypesand the existing unused-parameter allowance; zero diagnostics.name, passes on this change.git diff --check, independent review, and clean merge-tree against current master pass. No open sibling PRs.Limitations
Local build uses retained PHP headers/configuration and LibXL rather than a fresh phpize/configure install. Local checks cover Linux PHP 8.4 only; platform/version coverage is left to repository CI. Seven platform/license-specific PHPT skips are not passes. No performance claims.