Repository navigation
[Vulcan] Clarify nullable ExcelFormat property parameters - #336
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mixedtoint|null, matching their existing signatures.Validation
git diff --checkand actual merge-tree with current master clean. No open sibling PRs.Limitations
Local validation uses retained PHP headers and LibXL with a direct compiler build, not fresh phpize/configure. Local checks cover Linux PHP 8.4 only; skips are not passes. Exact published commit
5636ae80a4556c461c54bd1f28283a0bcadd84cd: all 36 executed CI jobs passed; one release-upload job intentionally skipped. Both Tests and Windows Build workflows completed successfully. Linux PHP 8.1–8.6, LibXL 4.6/5.1/5.2, ZTS, both ASAN lanes, PIE, stubs and all 20 Windows variants passed. Representative logs: PHP 8.4 Linux 252 passed / 9 skipped; ZTS 253 / 8; Windows PHP 8.4 x64 NTS 247 passed; both ASAN lanes 250 passed / 9 skipped plus separate targeted checks. No performance claim.