Skip to content

[Vulcan] Clarify nullable ExcelFormat property parameters - #336

Merged
iliaal merged 1 commit into
masterfrom
docs/format-nullable-parameters
Oct 25, 2026
Merged

iliaal merged 1 commit into
masterfrom
docs/format-nullable-parameters

Conversation

@iliaal

@iliaal iliaal commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Correct 14 individual border/fill parameter docblocks from mixed to int|null, matching their existing signatures.
  • Explain that omitted or null arguments read the current value, unlike the separately documented write-only border setters.
  • Add an Unreleased documentation note. No runtime/API changes.

Validation

  • Fresh strict native build with PHP 8.4.26 NTS / LibXL 5.2.0.1 trial: zero diagnostics.
  • Full PHPT suite: 254 passed, 7 platform/license-specific skips, zero failed or warned.
  • All 12 reference files lint; 28 XLS/XLSX signature/getter/setter/null/type contracts pass.
  • Independent 14-method documentation contract fails baseline and passes candidate; non-comment PHP tokens unchanged.
  • All 300 baseline blobs/modes verified against live GitHub tree, final tree matches tested local tree; git diff --check and actual merge-tree with current master clean. No open sibling PRs.

Limitations

Local validation uses retained PHP headers and LibXL with a direct compiler build, not fresh phpize/configure. Local checks cover Linux PHP 8.4 only; skips are not passes. Exact published commit 5636ae80a4556c461c54bd1f28283a0bcadd84cd: all 36 executed CI jobs passed; one release-upload job intentionally skipped. Both Tests and Windows Build workflows completed successfully. Linux PHP 8.1–8.6, LibXL 4.6/5.1/5.2, ZTS, both ASAN lanes, PIE, stubs and all 20 Windows variants passed. Representative logs: PHP 8.4 Linux 252 passed / 9 skipped; ZTS 253 / 8; Windows PHP 8.4 x64 NTS 247 passed; both ASAN lanes 250 passed / 9 skipped plus separate targeted checks. No performance claim.

@iliaal
iliaal merged commit 892940d into master Oct 25, 2026
37 checks passed
@iliaal
iliaal deleted the docs/format-nullable-parameters branch October 25, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant