Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the existing workbook-wide wrapper invalidation performed by
ExcelSheet::removeFilter()andExcelTable::removeFilter(). Even a no-op removal invalidates all existing autofilter/filter-column wrappers in that workbook; owners and filters in other workbooks survive. Callers must re-fetch surviving filters. No runtime behavior changes.Add regression coverage for both sheet/table directions, no-op removals, surviving owners, re-fetched filter ranges, and workbook isolation. Test 260 runs on the supported LibXL floor; table coverage in 261 requires LibXL 5.2. Numbers avoid sibling PR #338's test 259.
Validation
git diff --checkpass; independent native/source review passed.Limitations: native build reused official headers/library, not a fresh phpize/configure; no local Windows/ZTS/sanitizer or performance claim. GitHub CI for exact head
89ef1c72bf19691daf16f96a3d88cd06fc0af13acompleted successfully: Tests and Windows Build, 36 jobs passed, 1 release-attachment job intentionally skipped (not a pass). All 36 job logs verified against the exact-head merge commit; test summaries show zero failures/warnings. Regression 260 executes on LibXL 4.6/5.1/5.2 lanes; 261 is version-gated to 5.2; both execute in PHP 8.4 ZTS/ASAN lanes.