Repository navigation
fix(export): fill corners of circular jpeg exports - #106
Merged
Merged
Conversation
JPEG has no alpha channel, so the transparent corners left by the circle mask encoded as black. The background is painted behind the masked image, so filling it keeps the circle intact. Closes #103
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 99.75% 99.75% -0.01%
==========================================
Files 7 7
Lines 832 831 -1
Branches 144 144
==========================================
- Hits 830 829 -1
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circular JPEG exports had black corners: the auto white fill was skipped for
shape="circle", and JPEG drops the alpha the mask leaves behind.Changes
fillColoror#fff), whatever the shape. The fill is painted behind the masked image, so the circle stays intact.Testing
Closes #103