Repository navigation
Avoid deprecated XML_GetCurrent{Line,Column}Number - #95
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The version-gated implementation preserves backward compatibility while avoiding deprecated APIs.
0 open findings
What changed in this PR
Updates XML error reporting to use Expat’s non-deprecated 64-bit location APIs when available.
Changes:
- Uses 64-bit line and column APIs with Expat 2.9+.
- Retains compatibility with older Expat releases.
| File | Description |
|---|---|
index/mod_grs_xml.c |
Selects the appropriate Expat location API by version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.