Repository navigation
Cleanup test gils scripts - #97
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Background client failures are currently discarded by the shared cleanup routine.
1 open finding
What changed in this PR
Cleans up GILS shell tests by centralizing teardown and simplifying failure handling.
Changes:
- Adds shared server/client cleanup logic and
set -e. - Uses
testclientoptions for count checks and delays. - Reduces redundant timing-test iterations and sleeps.
| File | Description |
|---|---|
test/gils/cleanup.sh |
Adds shared process and record cleanup. |
test/gils/Makefile.am |
Distributes the cleanup helper. |
test/gils/stop01.sh |
Modernizes one-shot server testing. |
test/gils/stop02.sh |
Uses shared cleanup for static mode. |
test/gils/stop03.sh |
Improves threaded-mode handling. |
test/gils/stop04.sh |
Updates forked-server shutdown testing. |
test/gils/test1.sh |
Simplifies search count assertions. |
test/gils/test2.sh |
Simplifies update/search assertions. |
test/gils/test3.sh |
Streamlines compound-query checks. |
test/gils/timing1.sh |
Removes unnecessary sleeps and repetitions. |
test/gils/timing2.sh |
Clarifies timestamp-dependent behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.