Repository navigation
Windows installer fixes - #99
Merged
Merged
Conversation
Include all DLLs. Use macro InstallVSRedist from m4.
There was a problem hiding this comment.
🔵 Needs a closer look
The shared InstallVSRedist implementation is unavailable in the checkout, preventing verification of runtime installation behavior.
0 open findings
What changed in this PR
Updates Windows installer packaging and delegates Visual C++ runtime installation to the shared m4 macro.
Changes:
- Packages all DLLs from the binary directory.
- Uses
InstallVSRedistand updates the homepage shortcut to HTTPS. - Cleans up makefile whitespace and removes a commented-out copy command.
| File | Description |
|---|---|
| win/zebra.nsi | Updates DLL packaging, runtime installation, and homepage URL. |
| win/makefile | Removes trailing whitespace and an obsolete comment. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include all DLLs.
Use macro InstallVSRedist from m4.