Repository navigation
Fix build with PHP 8.6.0RC3 - #34
Conversation
remicollet
commented
Oct 13, 2026
. The WRONG_PARAM_COUNT and ZEND_WRONG_PARAM_COUNT() macros have been
removed. Call zend_wrong_param_count(); followed by RETURN_THROWS();
instead.
. The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed.
Call zval_ptr_dtor_nogc() directly instead.
There was a problem hiding this comment.
Using these feature unconditionally changes the required mininum version.
The description says: RETURN_THROWS() -- which is PHP 8 only. But that seems not be used.
zval_ptr_dtor_nogc() is PHP 7.
Argument free declaration of zend_wrong_param_count() is PHP 7.
So in a number of places the code can be simplied if PHP 7 is now the minimum requirement. This can be a separate commit.
There was a problem hiding this comment.
🟡 Changes recommended
Unconditional destructor replacements break the declared PHP 5 compatibility.
1 open finding
What changed in this PR
Updates Zend API usage for PHP 8.6 compatibility.
Changes:
- Replaces removed parameter-count macros.
- Replaces the removed
zval_dtor()alias.
| File | Description |
|---|---|
php_yaz.c |
Updates removed Zend API usages. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| zval_dtor(pval_res); | ||
| zval_ptr_dtor_nogc(pval_res); |
|
thx @remicollet |
|
Sorry to have miss the compatibility with PHP 5.x |
