Repository navigation
Directory search options - #79
Merged
Merged
Conversation
kurtnordstrom
marked this pull request as ready for review
October 14, 2026 02:00
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss,
ihardy,
jakub-id and
skomorokh
as code owners
October 14, 2026 02:00
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The search and filtering behavior is consistent and comprehensively covered by focused tests.
0 open findings
What changed in this PR
Adds directory search indexes and filters while improving navigation-state handling and test coverage.
Changes:
- Adds description/symbol searches plus entry-type and pickup-location filters.
- Preserves filters across searches, pagination, and browser navigation.
- Removes a duplicate ILL configuration field mapping.
| File | Description |
|---|---|
ui-rsdir/translations/ui-rsdir/en.json |
Adds search and filter labels. |
ui-rsdir/src/routes/ILLConfigRoute.js |
Removes duplicate loan-period mapping. |
ui-rsdir/src/routes/EntriesRoute.js |
Builds CQL for new indexes and filters. |
ui-rsdir/src/components/SearchAndFilter.js |
Adds search options and filter controls. |
ui-rsdir/src/components/Entries.js |
Passes filter state and handlers. |
ui-rsdir/src/routes/EntriesRoute.test.js |
Covers search, filtering, navigation, and pagination. |
ui-rsdir/src/index.test.js |
Scopes create-form interactions to its pane. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.