Repository navigation
Allow filling request by upload when supply enabled ILLDEV-554 - #80
Merged
Merged
Conversation
skomorokh
requested review from
JanisSaldabols,
adamdickmeiss,
ihardy,
jakub-id and
kurtnordstrom
as code owners
October 14, 2026 01:28
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Reopening the secondary-action modal can permit overlapping uploads and prematurely re-enable submission.
1 open finding
What changed in this PR
Adds optional DMS file uploads to supply-document actions.
Changes:
- Uploads files and populates delivery URLs.
- Adds DMS dependency, interface declaration, messages, and tests.
- Sets upload limits to 100 MB.
| File | Description |
|---|---|
yarn.lock |
Locks upload dependencies. |
ui-rs/translations/ui-rs/en.json |
Adds upload messages. |
ui-rs/src/components/Flow/primaryActions/SupplyDocument.test.js |
Tests upload behavior. |
ui-rs/src/components/Flow/primaryActions/SupplyDocument.js |
Integrates uploads into the primary action. |
ui-rs/src/components/Flow/moreActions/SupplyDocument.test.js |
Updates secondary-action test setup. |
ui-rs/src/components/Flow/moreActions/SupplyDocument.js |
Integrates uploads into the modal action. |
ui-rs/src/components/Flow/DocumentUpload.js |
Implements DMS uploading. |
ui-rs/package.json |
Declares dependency and optional interface. |
stripes-reshare/testing/stripesCore.js |
Mocks interface gating. |
platform-rs-dev/stripes.config.js |
Sets a 100 MB limit. |
environments/platform-zfldev/stripes.config.js |
Sets a 100 MB limit. |
environments/platform-resharexmigration/stripes.config.js |
Sets a 100 MB limit. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.