Repository navigation
ILLDEV-540 Make the placeholder picker easier to use - #81
Open
JanisSaldabols wants to merge 1 commit into
Open
JanisSaldabols wants to merge 1 commit into
JanisSaldabols wants to merge 1 commit into
Conversation
JanisSaldabols
requested review from
adamdickmeiss,
ihardy,
jakub-id,
kurtnordstrom and
skomorokh
as code owners
October 14, 2026 12:59
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated CSS places spacing after the final group instead of between groups.
1 open finding
What changed in this PR
Improves the template placeholder picker’s layout and scanability.
Changes:
- Sorts placeholders alphabetically within groups.
- Uses a large modal and removes descriptions.
- Adds tests for modal sizing and ordering.
| File | Description |
|---|---|
TemplateForm.js |
Updates placeholder presentation and sorting. |
TemplateForm.css |
Adjusts placeholder group spacing. |
TemplateForm.test.js |
Tests the new layout and ordering. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.