Repository navigation
Build for Windows using vcpkg - #215
Merged
Merged
Conversation
Windows nmake: use vcpkg layout. Something along the lines of: cd C:\vcpkg vcpkg install libxml2:x64-windows libxslt:x64-windows vcpkg install icu:x64-windows
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Dependency DLL naming and ICU version assumptions can cause the documented Windows build to fail.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates Windows NMAKE builds to use vcpkg dependencies and architecture-specific configuration.
Changes:
- Adds x86/x64 architecture detection and vcpkg paths.
- Updates dependency DLL staging and installer labeling.
- Documents vcpkg-based Windows setup.
| File | Summary |
|---|---|
win/yaz.nsi |
Adds architecture information to installer text. |
win/makefile |
Configures vcpkg dependencies and architecture-specific builds. |
doc/book.xml |
Documents vcpkg installation and Windows build steps. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows nmake: use vcpkg layout. Something along the lines of: cd C:\vcpkg
vcpkg install libxml2:x64-windows libxslt:x64-windows vcpkg install icu:x64-windows