Repository navigation
Conversation
|
|
rov-adhoc
force-pushed
the
18.0-h-127730-rov
branch
from
September 18, 2026 12:34
4a41783 to
1bfbe7b
Compare
rov-adhoc
changed the title
- AccountJournal._search only forces active_test=False when it is not loading module data with tests enabled - Do not mutate the caller domain list in _search Change note: Ajuste interno en la carga de datos de los diarios durante las pruebas automáticas. No cambia el comportamiento del sistema para los usuarios.
rov-adhoc
force-pushed
the
18.0-h-127730-rov
branch
from
September 18, 2026 13:05
1bfbe7b to
1ab3904
Compare
Contributor
|
@roboadhoc r+ nobump |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AccountJournal._searchforcesactive_test=Falseon every search, so with this module installed any plain search onaccount.journalalso returns archived journals. This keeps that behaviour, except while module data is being loaded with tests enabled.Why
Archived journals have to stay reachable from a plain search: that is what lets them be seen and unarchived from the store form, which is why the override was added in #77.
The side effect is on the test side.
l10n_argot a test upstream (e471c26fcc6a, 2026-08-18) that archives the export journal and invoices a foreign partner;_onchange_partner_journalfinds the archived journal anyway and assigns it, so the test fails and the 18.0 runbot goes red on the[18.0] Alltrigger, where this module is installed.Also,
_searchno longer mutates the domain list it receives.Test plan
pre-commit run --fileson the changed file: passed.TestArManual.test_foreign_partner_without_expo_journalon the full 18.0 database.Internal reference: https://www.adhoc.inc/odoo/helpdesk.ticket/127730