fix: adds validation on auto complete request payload - #3924
Open
thoniTUB wants to merge 5 commits into
Open
Conversation
thoniTUB
commented
Jul 29, 2026
| import { filterSuggestionToSelectOption } from "./suggestionsHelper"; | ||
|
|
||
| const PAGE_SIZE = 25; | ||
| const MAX_AUTOCOMPLETE_TEXT_LENGTH = 500; |
Collaborator
Author
There was a problem hiding this comment.
@awildturtok ich reiche den Wert nicht vom Backend durch, damit jetzt nicht noch die API angepasst werden muss
thoniTUB
marked this pull request as ready for review
July 29, 2026 08:55
awildturtok
approved these changes
Jul 29, 2026
| final List<FrontendValue> resolved = new ArrayList<>(terms.size()); | ||
|
|
||
|
|
||
| // TODO also use Solr's POST method to avoid too long URIs (see sendQuery) |
| } | ||
|
|
||
| public record AutocompleteRequest(@NonNull Optional<String> text, @NonNull OptionalInt page, @NonNull OptionalInt pageSize) { | ||
| public record AutocompleteRequest( |
Collaborator
There was a problem hiding this comment.
ah, das ist die Magic Sauce! Cool
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| #!/usr/bin/env bash | |||
Collaborator
There was a problem hiding this comment.
gute aber unrelated änderung heir?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.