Skip to content

Fix macOS and R-devel CI checks - #327

Merged
Melkiades merged 1 commit into
mainfrom
ci_macos_xquartz_rdevel_warning@main
Oct 12, 2026
Merged

Melkiades merged 1 commit into
mainfrom
ci_macos_xquartz_rdevel_warning@main

Conversation

@Melkiades

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

  • CI and test only, no user-facing change (no NEWS entry).

  • R-CMD-check.yaml: install XQuartz on macOS. gdtools (used by flextable) is linked against X11, which the macOS runners no longer ship, so every example using flextable failed with "Library not loaded: /opt/X11/lib/libXrender.1.dylib".

  • test-add_forest.R: expect_no_warning() changed to expect_no_error() when rendering the gt forest plot. R-devel warns upstream on the out-of-range test values ("object length is not a multiple of subscript length"); the warning does not come from crane code.

Both failures are on main and block #326.


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files  326 suites   2m 0s ⏱️
326 tests 326 ✅ 0 💤 0 ❌
942 runs  942 ✅ 0 💤 0 ❌

Results for commit 1c9c20f.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tbl_hierarchical_incidence_rate 💔 $8.33$ $+1.11$ tbl_hierarchical_incidence_rate_runs_with_minimum_arguments
tbl_mmrm 💔 $1.06$ $+1.42$ se_calculates_standard_error_correctly
tbl_proportion 💚 $4.35$ $-1.26$ tbl_proportion_binary_summary_works
tbl_rmpt 💔 $3.47$ $+1.68$ tbl_rmpt_works_with_default_parameters_Example_1_
tbl_roche_subgroups 💚 $8.69$ $-1.13$ tbl_roche_subgroups_time_to_event_NULL_works
tbl_shift 💔 $0.58$ $+1.65$ tbl_shift_strata_location_
tbl_survfit_times 💚 $2.01$ $-1.61$ tbl_survfit_times_works

Results for commit 67b2078

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                          63       0  100.00%
R/add_difference_row.R                     101       0  100.00%
R/add_forest_utils.R                        97      10  89.69%   76-79, 94-100
R/add_forest.R                             139       0  100.00%
R/add_hierarchical_count_row.R              33       0  100.00%
R/add_label_column.R                        26       0  100.00%
R/add_proportion_difference.R              150       1  99.33%   245
R/add_proportion_odds_ratio.R               57       0  100.00%
R/adjust_stat_columns_wrap.R                29       1  96.55%   59
R/annotate_gg_km.R                         141       0  100.00%
R/annotate_gg_pkc.R                        100       0  100.00%
R/annotate_gg.R                             94       0  100.00%
R/ard_tabulate_abnormal_by_baseline.R       65       0  100.00%
R/crane-package.R                            2       2  0.00%    26-27
R/deprecated.R                              21      21  0.00%    18-54
R/df_add_poolings.R                         41       0  100.00%
R/get_cox_pairwise_df.R                    163       0  100.00%
R/gg_km_utils.R                             39      14  64.10%   20-37
R/gg_km.R                                  143      37  74.13%   55-58, 75, 102, 176-181, 184-187, 197-199, 204-205, 239-241, 248-251, 255, 266-270, 283, 285-287
R/gg_lineplot.R                            121       0  100.00%
R/gg_mmrm_lineplot.R                       102       1  99.02%   106
R/gg_pkc_lineplot.R                         98       0  100.00%
R/gg_utils.R                               222       0  100.00%
R/label_roche.R                             72       0  100.00%
R/modify_header_rm_md.R                     18       2  88.89%   35-36
R/modify_split_caption.R                    37       0  100.00%
R/modify_zero_recode.R                      20       1  95.00%   64
R/pk_helper.R                              499       0  100.00%
R/reverse_difference_ci.R                   33       0  100.00%
R/tbl_baseline_chg.R                       188       0  100.00%
R/tbl_coxph.R                               90       1  98.89%   229
R/tbl_hierarchical_incidence_rate.R        291       4  98.63%   430-433
R/tbl_hierarchical_rate_and_count.R        339      13  96.17%   343, 425, 446-456
R/tbl_hierarchical_rate_by_grade.R         317       3  99.05%   169-171
R/tbl_listing.R                             36       0  100.00%
R/tbl_mmrm.R                               344       6  98.26%   452-456, 548
R/tbl_null_report.R                         10       0  100.00%
R/tbl_proportion.R                         141      13  90.78%   100-103, 107-111, 114-117
R/tbl_rmpt.R                               157      12  92.36%   299-304, 316-321
R/tbl_roche_subgroups.R                    157       0  100.00%
R/tbl_roche_summary.R                       64       0  100.00%
R/tbl_shift.R                              111       0  100.00%
R/tbl_survfit_quantiles.R                  154       0  100.00%
R/tbl_survfit_times.R                       92       0  100.00%
R/tbl_with_pools.R                          79       1  98.73%   317
R/theme_gtsummary_roche.R                   87       1  98.85%   61
R/utils.R                                   42       0  100.00%
TOTAL                                     5425     144  97.35%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 1c9c20f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@wzfrank wzfrank left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for fixing the CICD.

@Melkiades
Melkiades merged commit d0099c3 into main Oct 12, 2026
@Melkiades
Melkiades deleted the ci_macos_xquartz_rdevel_warning@main branch October 12, 2026 07:18
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants