SYS-696 dual image publishing to ghcr and docker hub - #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When new images are built, they're now promoted to both dockerhub and ghcr.io. This also cleans up some old cruft which hasn't been used since this repo transitioned from dockerhub's internal build service to GitLab a few years ago.
Why is this change being made?
Some existing and potential users prefer GitHub's ghcr.io registry over Docker Hub.
How was this tested? How can the reviewer verify your testing?
Manual until this worked in a branch under CI.
Completion checklist