feat(ui-text-input,ui-select): add contentSpacing prop for even wrapped-tag padding in multiple Select#2606
Open
ToMESSKa wants to merge 2 commits into
Open
Conversation
|
Visual regression report
Diff images (29)alert.png — 3444 pixels differbadge.png — 1300 pixels differbillboard.png — 10930 pixels differbreadcrumb.png — 9136 pixels differbutton-and-derivatives.png — 13604 pixels differbyline.png — 5878 pixels differcalendar.png — 7170 pixels differcheckbox.png — 5095 pixels differcheckboxgroup.png — 8807 pixels differcolorpicker.png — 26341 pixels differcontextview.png — 9344 pixels differdateinput-dateinput2.png — 3755 pixels differdatetimeinput.png — 4776 pixels differdrilldown.png — 9731 pixels differfiledrop.png — 20401 pixels differform-errors.png — 34246 pixels differheading.png — 17393 pixels differlink.png — 21258 pixels differmenu.png — 4949 pixels differmetric-pill-tag-timeselect-text.png — 21956 pixels differoptions.png — 96793 pixels differpagination.png — 1692 pixels differprogressbar.png — 1421 pixels differselect-simpleselect.png — 7058 pixels differtable.png — 8866 pixels differtabs.png — 2863 pixels differtooltip.png — 44534 pixels differtreebrowser.png — 6805 pixels differview.png — 17107 pixels differBaselines come from the |
15375f4 to
22196a0
Compare
22196a0 to
2366123
Compare
git-nandor
requested changes
Jul 1, 2026
| <div> | ||
| <Select | ||
| renderLabel="Multiple Select" | ||
| contentSpacing="even" |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
@git-nandor Nice catch, I fixed it, can you please check again?
2366123 to
5a58d6b
Compare
997069c to
738fead
Compare
git-nandor
approved these changes
Jul 2, 2026
1bbd315 to
c1b5831
Compare
…ed-tag padding in multiple Select INSTUI-5079
…lines InstUI's font stack is `LatoWeb, Lato, "Helvetica Neue", Helvetica, Arial, sans-serif`, but the regression app loaded no Lato, so text fell back to the OS font — Helvetica Neue on macOS, DejaVu Sans in the Linux CI container. Those fonts have different metrics, so layout-driven components (e.g. the multiple Select with `contentSpacing="even"`, whose height follows tag wrapping) rendered at different heights locally vs in CI, breaking the diff. - Self-host Lato via @fontsource/lato (weights 300/400/700) so the stack resolves to a real, bundled font identically in every environment. - Wait for `document.fonts.ready` before each screenshot so captures never happen mid font-load in a fallback face. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
c1b5831 to
172dbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






























INSTUI-5094 (includes regression-test font-determinism fix)
INSTUI-5079
ISSUE:
-TEST PLAN: