Repository navigation
feat(eval): add eval headroom to flag items with no headroom #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
70
commits into
intel:main
Choose a base branch
from
napetrov:feat/eval-ceiling-floor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
2226252
feat(eval): flag arms items at the ceiling or floor with no headroom
napetrov 87335ba
fix(eval): compare the unrounded headroom mean to the ceiling
napetrov 0965221
fix(headroom): flag means exactly at a threshold despite float rounding
napetrov df78ff5
fix(headroom): refuse unknown no-skill arms, count distinct runs
napetrov 050de2e
fix(headroom): reps follow the no-skill arm, unscored arms skip the f…
napetrov 38d219c
docs(eval): document the headroom threshold range checks
antonwolfy 536a3b7
Merge branch 'main' of https://github.com/intel/dokimi into feat/eval…
napetrov d5113e0
Address review: pin the baseline term of the floor test
napetrov 15695ac
Address review: drive non-default thresholds through the headroom com…
napetrov 4bbc04a
Address review: run the headroom command through the real parser
napetrov 329baac
Address review: pin each summary counter with a mixed item set
napetrov 19b25df
Address review: pin the item order of the headroom result
napetrov 8e5245e
Address review: match the threshold refusals and pin their boundaries
napetrov 544394e
Address review: cover empty and unjudged headroom input
napetrov fe66ffc
Address review: pin a given no-skill arm on the success path
napetrov 95f84dd
Thread: IC_kwDOVBg7g88AAAABgreQtQ: already fixed in 544394ef
napetrov e5faa92
fix(headroom): exit 2 on an input nested too deeply to read
napetrov 37cd2c8
fix(headroom): --min-reps refuses 0 with the usage message
napetrov 744e1ca
fix(headroom): keep a non-ASCII digit question id instead of refusing it
napetrov b3a0b78
fix(headroom): refuse -o naming one of the input runs
napetrov 49a4d54
fix(headroom): count a re-serialized copy of a run once
napetrov 340879b
fix(headroom): summarize the unscored-arm note per arm
napetrov 2c22659
fix(headroom): a floor needs the no-skill arm scored on the item
napetrov aa8c3ad
fix(headroom): refuse a file where no run scored the no-skill arm
napetrov f4328af
Merge remote-tracking branch 'intel/main' into pr279-1029
napetrov 3df832a
docs(headroom): a repeat is skipped by JSON content, not by bytes
napetrov 95642eb
docs(headroom): keep the tolerance comment to two lines
napetrov 2563839
docs(headroom): a floor needs the no-skill arm scored
antonwolfy 9a191ba
docs(headroom): list the other exit-2 cases and the score scale
antonwolfy 108ad9f
Merge remote-tracking branch 'intel/main' into pr279-1029
napetrov 7b69f5a
test(cli): allowlist the four eval headroom flags with reasons
napetrov f259a4f
fix(headroom): the -o guard survives an unresolvable path; floor word…
napetrov 9872a50
docs(cli): regenerate the CLI snapshot for eval headroom
napetrov df428e3
fix(headroom): refuse a positive ceiling or floor below one score step
napetrov 1e164b8
fix(headroom): guard the .rejected sibling of -o, sort long digit ids…
napetrov 6a1e7f2
docs(headroom): state the threshold ranges the code accepts
napetrov dfd6946
test(headroom): pin the -o guard against a dotdot spelling of an input
napetrov 5902eda
fix(headroom): refuse a directory as -o with exit 2, not a ValueError
napetrov 438c642
fix(headroom): refuse a directory spelled with a trailing slash as -o
napetrov ebe6575
fix(headroom): refuse "newdir/." and an unstat-able -o without a crash
napetrov d56fd0d
fix(headroom): name the -o refusal as "not a file name" and pin the c…
napetrov 8118952
docs(headroom): the provisional rule counts reps across files; name t…
napetrov 6eea8e2
style(test): keep the directory-output test comment to two lines
napetrov c0fbf44
Merge remote-tracking branch 'intel/main' into tidy279-eval
napetrov 6399536
feat(eval): eval headroom takes the registry's flag names and a route…
napetrov 58891e3
fix(eval): an empty --out is refused, not skipped
napetrov 156c82d
fix(eval): a failed write of --out exits 1, not 2
napetrov 096503d
Merge remote-tracking branch 'intel/main' into tidy279-eval
napetrov 6c29745
chore(cli): regenerate the CLI snapshot after merging main
napetrov b971c61
fix(runs): list headroom.v1 in the runs kinds table
napetrov 97f0f7a
fix(eval): exit 2 when eval headroom cannot write --out
xaleryb 976f06a
fix(eval): refuse eval headroom inputs of different configurations
xaleryb aa49e53
fix(eval): refuse an arms input whose run_config is not an object
napetrov eabdcda
fix(eval): exit 2 when a top-level arms or run_config has the wrong s…
napetrov 6ea6c6b
Merge remote-tracking branch 'intel/main' into tidy279-eval
napetrov 1494b6c
docs(eval): say which top-level shapes the headroom check refuses and…
napetrov c574718
fix(eval): refuse a judge_context mix and non-string arm names in hea…
napetrov 6699e21
fix(headroom): refuse inputs that give one question id different ques…
napetrov 02d5d91
fix(headroom): refuse pooled runs that differ in scorer, grounding or…
napetrov d363baf
docs(eval): give the 1e-6 minimum in the headroom threshold ranges
antonwolfy 998f1f5
fix(headroom): refuse legacy and rescored runs that differ, and malfo…
napetrov 7d38dd1
style(headroom): shorten the _fmt comment to the two-line limit
napetrov 61b942d
docs(headroom): say up to nine decimals, as _fmt floors them
napetrov 3c0ff3a
test(headroom): pin that _fmt floors at the ninth decimal
antonwolfy 6258e3a
fix(headroom): a mean 1e-9 from a threshold is not read as at it
napetrov 87f1c50
Merge intel/main into pr279-land1031
napetrov 84e7888
Merge remote-tracking branch 'intel/main' into pr279-land1031
napetrov 649b56b
fix(headroom): compare thresholds exactly; empty arms list counts as …
napetrov c31a660
test(headroom): split test_headroom.py under the 1000-line test cap
napetrov 973a112
fix(headroom): table floors the displayed score from its exact decimal
napetrov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
dokimi/changelog.d/20261028_120000_napetrov_feat-eval-headroom.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ### Added | ||
|
|
||
| - **`eval headroom` flags arms items with no headroom** — reads one or more `arms.v1` files of the same question set and flags an item as a `ceiling` when the no-skill arm's mean is at least `--ceiling` (default 0.9, on 0-1), or as a `floor` when the no-skill arm was scored, every arm that a run scored has a mean at most `--floor` (default 0), and at least one arm other than the no-skill arm scored. An item with fewer than `--min-reps` runs (default 3) scoring its no-skill arm is `provisional`. The human table goes to stdout; `--out` writes a `headroom.v1` artifact with every item. The flags change no score. Inputs that are not repetitions of one configuration (model, judge, run config other than the seed, harness, arms or library differ) exit 2. Pooling also refuses a file scored by `eval reference` next to a judged one, an arm whose profile prompt digest changed, and a question judged grounded in one file and ungrounded in another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.