chore(codefactor): exclude the vendored task-format fixtures by napetrov · Pull Request #352 · intel/dokimi

napetrov · 2026-11-01T18:37:46Z

Summary

.codefactor.yml is dropped. CodeFactor documents exclusion as repository Settings → Ignore Files, not an exclude_paths key in a config file, so the file had no proven effect.

Maintainer action: add this pattern under CodeFactor Settings → Ignore Files:

dokimi/tests/fixtures/task_formats/**

The paths are the vendored upstream task-format fixtures from #210 (90 files), not our code.

Evidence

Net diff of this PR is empty after 627edc9b; the change is the removal of the file in that commit.
Until the Ignore Files pattern is set, CodeFactor keeps analysing dokimi/tests/fixtures/task_formats/.

Merge Danger

Door: two-way. Nothing to revert.

Blast Radius: CodeFactor report only. No effect on tests, build or CI.

🤖 Generated with Claude Code

tests/fixtures/task_formats holds upstream task files copied in with intel#210; CodeFactor should not report on them. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>

Copilot

🔵 Needs a closer look

The PR’s sole effect depends on unverified CodeFactor support for .codefactor.yml and exclude_paths, requiring confirmation that the fixture directory is actually excluded.

No open issues 🎉

What changed in this PR

0 new findings; nothing to fix identified.

This PR adds configuration intended to exclude vendored task-format fixtures introduced in #210 from CodeFactor analysis.

Changes:

Adds an exclusion for dokimi/tests/fixtures/task_formats/**.
Leaves application code, tests, and CI unchanged. Whether CodeFactor honors this configuration remains unverified.

File	Description
`.codefactor.yml`	Adds the vendored-fixture exclusion pattern for CodeFactor.

_{Review effort: Balanced}

exai-bot · 2026-11-01T18:41:22Z

🔍 OpenCodeReview found 1 issue(s) in this PR.

By severity: 1 medium

Severity	Category	Location	Finding
medium	bug	.codefactor.yml:5	Must-fix: CodeFactor's documented exclusion mechanism is repository Settings → Ignore Files, not an `exclude_paths` key in `.codefactor.y...

Review details

Commit reviewed: c3441b8 against merge base 93a5062
Coverage: 1 files in 1 groups
Engine: OpenCodeReview v1.13.3, us.openai.gpt-6.1-sol
Usage: 29k tokens (13k from cache), 12s
Tool calls: 3 (1 code_comment, 1 code_search, 1 file_read)
.codefactor.yml: 1 file

exai-bot · 2026-11-01T18:41:23Z

+# SPDX-License-Identifier: Apache-2.0
+
+# Vendored upstream task-format fixtures (#210): not our code, not reviewed here.
+exclude_paths:


Must-fix: CodeFactor's documented exclusion mechanism is repository Settings → Ignore Files, not an exclude_paths key in .codefactor.yml. There is no repository-side consumer of this configuration either, so adding this file does not establish the intended exclusion; the fixtures can continue to be analyzed. Apply the exclusion through CodeFactor's supported setting and verify it in a subsequent analysis, or provide evidence that CodeFactor actually consumes this file before relying on it.

Decision needed (maintainer), not changed yet. The exclude_paths key in .codefactor.yml may be inert: CodeFactor documents exclusion as Settings → Ignore Files.
Options: (a) drop the file and add dokimi/tests/fixtures/task_formats/** under Settings → Ignore Files (recommended, documented path, verifiable in the next analysis); (b) keep the file only with a CodeFactor doc or report showing it reads .codefactor.yml.
Recommendation: (a). Holding until you pick.

Maintainer decision: option (a). Dropped .codefactor.yml in 627edc9 (no config key left).
The glob dokimi/tests/fixtures/task_formats/** goes in CodeFactor Settings → Ignore Files (maintainer action, noted in the PR body).
The PR diff is now empty; the PR body says so.

antonwolfy

The file is well-formed and the glob matches the vendored fixtures, but nothing shows that CodeFactor reads it. One point to settle before merge, inline.

What I ran, on a Linux review host at c3441b8:

make ci-local: 30 passed, 0 failed, 7 skipped (docker, network, semgrep and other jobs that need the PR's own runner). Changed-line coverage passes; the PR touches no Python.
The YAML parses. dokimi/tests/fixtures/task_formats/** matches the tracked fixture files. The commit carries a Signed-off-by.

Checked, no issues

Scope: only .codefactor.yml is added. No test, build or CI file changes, so the stated blast radius holds.
Repo rules: no schema, docs page, nav entry or generated artifact is involved.

antonwolfy · 2026-11-01T21:36:04Z

+# SPDX-License-Identifier: Apache-2.0
+
+# Vendored upstream task-format fixtures (#210): not our code, not reviewed here.
+exclude_paths:


I agree with exai-bot and Copilot here; what I add is below.

Nothing in the PR shows that CodeFactor honours exclude_paths in this file, so the exclusion may be inert.

The description says so itself: the CodeFactor docs it could read describe exclusion as repository Settings → Ignore Files, not a .codefactor.yml key. The repo has no other CodeFactor config and no check that consumes this file. dokimi/tests/fixtures/task_formats/MANIFEST.yaml:49 and :61 show these fixtures were already edited "for CodeFactor", so the tool does analyse them today. If the key is ignored, the report stays as noisy as before and the file reads as if the problem were solved. I could not check CodeFactor's behaviour from here, so this rests on the description and the docs it cites.

Suggestion: confirm on a CodeFactor run for this PR that the fixtures drop out of the report. If they do not, add the same glob under Settings → Ignore Files and drop this file, or keep it only with a comment saying the setting is what does the work.

Same decision as the reply above (Ignore Files vs exclude_paths). Holding; no change until the maintainer picks.

Maintainer decision: option (a). Dropped .codefactor.yml in 627edc9 (no config key left).
The glob dokimi/tests/fixtures/task_formats/** goes in CodeFactor Settings → Ignore Files (maintainer action, noted in the PR body).
The PR diff is now empty; the PR body says so.

CodeFactor documents exclusion under repository Settings -> Ignore Files, not an exclude_paths key in this file. The glob moves to that setting (maintainer action); see the PR body. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>

codecov-commenter · 2026-11-02T04:30:14Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.29%. Comparing base (93a5062) to head (627edc9).
⚠️ Report is 10 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   94.06%   94.29%   +0.23%     
==========================================
  Files         297      308      +11     
  Lines       38018    39322    +1304     
  Branches     6424     6651     +227     
==========================================
+ Hits        35760    37077    +1317     
+ Misses       1451     1432      -19     
- Partials      807      813       +6

see 39 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

napetrov · 2026-11-02T04:47:56Z

Closing: with .codefactor.yml dropped the diff is empty. To exclude the vendored fixtures, a maintainer adds dokimi/tests/fixtures/task_formats/** in CodeFactor Settings → Ignore Files.

chore(codefactor): exclude the vendored task-format fixtures

c3441b8

tests/fixtures/task_formats holds upstream task files copied in with intel#210; CodeFactor should not report on them. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>

Copilot AI balanced review requested due to automatic review settings November 1, 2026 18:37

napetrov requested a review from a team as a code owner November 1, 2026 18:37

Copilot started reviewing on behalf of napetrov November 1, 2026 18:38

View session

Copilot AI reviewed Nov 1, 2026

View reviewed changes

exai-bot reviewed Nov 1, 2026

View reviewed changes

antonwolfy reviewed Nov 1, 2026

View reviewed changes

chore(codefactor): drop .codefactor.yml

627edc9

CodeFactor documents exclusion under repository Settings -> Ignore Files, not an exclude_paths key in this file. The glob moves to that setting (maintainer action); see the PR body. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>

napetrov closed this Nov 2, 2026

Navigation Menu

Repository navigation

chore(codefactor): exclude the vendored task-format fixtures - #352

chore(codefactor): exclude the vendored task-format fixtures#352
napetrov wants to merge 2 commits into
intel:mainfrom
napetrov:codefactor-exclude

napetrov commented Nov 1, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

exai-bot commented Nov 1, 2026

Uh oh!

exai-bot Nov 1, 2026

Uh oh!

napetrov Nov 2, 2026

Uh oh!

napetrov Nov 2, 2026

Uh oh!

antonwolfy left a comment

Uh oh!

antonwolfy Nov 1, 2026

Uh oh!

napetrov Nov 2, 2026

Uh oh!

napetrov Nov 2, 2026

Uh oh!

codecov-commenter commented Nov 2, 2026

Uh oh!

napetrov commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

napetrov commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Evidence

Merge Danger

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

exai-bot commented Nov 1, 2026

Uh oh!

exai-bot Nov 1, 2026

Choose a reason for hiding this comment

Uh oh!

napetrov Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

napetrov Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

antonwolfy left a comment

Choose a reason for hiding this comment

Uh oh!

antonwolfy Nov 1, 2026

Choose a reason for hiding this comment

Uh oh!

napetrov Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

napetrov Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Nov 2, 2026

Codecov Report

Uh oh!

napetrov commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

napetrov commented Nov 1, 2026 •

edited

Loading