Add Wildcat Lake to supported CPU model table - #598
Closed
karanshukla wants to merge 1 commit into
Closed
karanshukla wants to merge 1 commit into
karanshukla wants to merge 1 commit into
Conversation
Wildcat Lake (family 6, model 0xd5) was missing from intel_id_table[], so check_cpu_id() failed to match and thermald exited at startup with "Unsupported cpu model or platform", despite the platform having working RAPL powercap sysfs and an INT3400 (INTC10FC) device with a populated GDDV data vault. Marked adaptive_only, consistent with the other recent client platforms (Lunar Lake, Arrow Lake, Panther Lake, Nova Lake), which are supported through GDDV adaptive tables rather than static thermal-conf.xml. Signed-off-by: Karan Shukla <karan_shukla@live.com>
Contributor
|
Already a commit in master for this. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildcat Lake (family 6, model 0xd5) is missing from
intel_id_table[], socheck_cpu_id()fails to match andcthd_engine_adaptive::thd_engine_init()exits with "Unsupported cpu model or platform". Because that path callsexit(EXIT_SUCCESS), systemd records a clean exit andRestart=on-failurenever fires, so the unit stays enabled while doing nothing.Marked
adaptive_only, consistent with the other recent client platforms (Lunar Lake, Arrow Lake, Panther Lake, Nova Lake). That third field is what makes this safe to add without any silicon-specific values: thermald carries no thermal constants for these platforms and reads GDDV out of firmware at runtime, so the entry asserts only that this platform is driven by its own firmware tables.Platform
0xD5) stepping 1INTC10FC:00INT3400 with a populated 1208-bytedata_vault,\_SB_.IETMAffects both Fedora's 2.5.9 package and master at
2d93d94(2.5.12-rc1).Testing
Built from master
2d93d94, installed to/usr/local/binand run via a systemd drop-in.Before:
thermald.serviceexits immediately at every boot.After: the daemon stays running, parses this machine's GDDV, selects target
Balance Mode-28C, and drivesrapl_controller_mmiobetween the firmware's ownPL1MIN 15000/PL1MAX 25000. Measured onintel-rapl-mmio:0/constraint_0_power_limit_uw:15000000before,25000000after.Nothing else in the adaptive path needed changes. thermald discovers INT3400 by scanning for a driver directory entry starting with
INT, so the newerINTC10FCACPI ID is picked up as-is.available_uuidsreadsUNKNOWNandcurrent_uuidreadsINVALID, which matches other recent client platforms where policy comes from GDDV rather than UUID selection.One limit worth stating: the passive throttle-down branch was not exercised. Under six cores of
openssl speed -evp aes-256-cbcfor four minutes,SEN1(the sensor GDDV binds the 54C passive trip to) peaked at 50C while the package reached 76C, so the trip was never crossed. That is a property of which sensor the platform's firmware selects, not of this change. Verified up to the trip, not through it.Note, not part of this patch
thd_platform_intel.cpp:157prints " Need Linux PowerCap sysfs" unconditionally on any table miss, without checking whether powercap is present. On this machine powercap is fully populated, so the message points at the wrong thing and is easy to chase for a while. Happy to send that separately if it is worth fixing.Unrelated
No overlap with #597, which touches the Qualcomm SPEL path in
thd_engine_default.cpp.