v2.5.13 - #600
Merged
Merged
v2.5.13 #600
Conversation
During thermald initialisation, read_cooling_devices() scans all qcom-spel:* nodes under /sys/class/powercap/ and creates a cthd_sysfs_cdev_spel object for every discovered domain/constraint combination. Because device_name is hardcoded to "SPEL" in the constructor, every object's update() call matches the single PPCC entry in the XML config and writes the PPCC-derived power limit to hardware — even for domains and constraints that the XML config never intended to manage. Fix this by consulting the XML <CoolingDevices> section before entering the SPEL discovery loop. A set of cdev type names that are explicitly listed in the config is built once; any discovered SPEL cdev whose generated type name (spel_controller_<domain>_pl<N>) is absent from that set is skipped before update() is called, preventing an unintended PL write to hardware. When no SPEL cdevs are listed in the XML config the set is empty and the guard is not entered, preserving the existing behaviour. Signed-off-by: Priyansh Jain <priyansh.jain@oss.qualcomm.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Priyansh Jain <priyansh.jain@oss.qualcomm.com>
… miss check_cpu_id() prints " Need Linux PowerCap sysfs" on any intel_id_table[] miss, without checking whether powercap is actually present. The message dates to 9b1fae1, where it was meant to state a requirement rather than a finding: an unmatched CPU can still be driven as long as the kernel exposes powercap sysfs. It reads as a diagnosis, so on a machine with a fully populated /sys/class/powercap/intel-rapl it points at the wrong subsystem and costs time to chase. Stat the path and report whichever case actually applies. Signed-off-by: Karan Shukla <karan_shukla@live.com>
Refer to README.txt for details. Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.5.13 release