Validator: allow more types for tags 1 (Unix time_t) , 21-23 (expected Base64 encodings) - #340
Open
thiagomacieira wants to merge 2 commits into
Open
thiagomacieira wants to merge 2 commits into
thiagomacieira wants to merge 2 commits into
Conversation
thiagomacieira
force-pushed
the
allow-more-types-in-cborvalidator
branch
from
October 2, 2026 20:54
15e710c to
b9b3d7b
Compare
This was a mistake in the original content. Even RFC 7049 said: > The tagged item can be a positive or negative > integer (major types 0 and 1), or a floating-point number (major type > 7 with additional information 25, 26, or 27) For intel#339. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
They were meant to tag byte strings, directly or indirectly. But the wording in RFC 7049 and 8949 is > The data item tagged can be a byte string or any other data item. That means it can be used to tag numbers and text strings, which in my opinion makes no sense, but let's allow them. For the testing, we can reuse and combine with the data for the other tag that accepted anything: the CBOR signature one. For intel#339. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
allow-more-types-in-cborvalidator
branch
from
October 2, 2026 20:57
b9b3d7b to
577d42b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Unix
time_t, this was a mistake in the original content. Even RFC 7049 said:For the base64 encoding expectations, the tags were meant to tag byte strings, directly or indirectly. But the wording in RFC 7049 and 8949 is
That means it can be used to tag numbers and text strings, which in my opinion makes no sense, but let's allow them.
Fixes #339