Skip to content

fix: avoid attr_value_t conversion of new_command result during module init #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wenzel merged 1 commit into from
Sep 11, 2026
+7 −5
Merged

fix: avoid attr_value_t conversion of new_command result during module init #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,8 +1064,14 @@ fn init() {
print("TSFFS initialized. Configure and use it as @tsffs.")
"#})
.expect("Failed to run python");
// NOTE: The result of `new_command` is bound to a variable so that this snippet is a
// statement rather than an expression. `SIM_run_python` converts the value of a trailing
// expression to an `attr_value_t`, and newer Simics Base versions return a `CliCommand`
// object from `new_command` rather than `None`. That object has no `attr_value_t`
// representation, so the conversion raises `SimExc_Type` even though the command itself
// was registered successfully. Binding the result avoids the conversion entirely.
run_python(indoc! {r#"
new_command(
_tsffs_init_command = new_command(
"init-tsffs",
init_tsffs_cmd,
[],
Expand All @@ -1075,9 +1081,5 @@ fn init() {
doc = "Initialize the TSFFS fuzzer"
)
"#})
.map_err(|e| {
error!(tsffs, "{e}");
e
})
.expect("Failed to run python");
}
Loading