Skip to content

Return 400 for invalid UTF-8 query parameters #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ydah wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return 400 for invalid UTF-8 query parameters #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/committee/schema_validator/open_api_3/operation_wrapper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def build_openapi_parser_option(validator_option, coerce_value)

def validate_get_request_params(query_params, headers, validator_option)
validate_query_params(query_params, headers, validator_option)
rescue OpenAPIParser::OpenAPIError => e
rescue OpenAPIParser::OpenAPIError, ArgumentError => e
raise Committee::InvalidRequest.new(e.message, original_error: e)
end

Expand Down
9 changes: 9 additions & 0 deletions test/middleware/request_validation_open_api_3_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,15 @@ def app
end

describe 'bracket-style query params' do
it 'returns a bad request for query parameters with invalid UTF-8 bytes' do
parameter = { 'name' => 'query_string', 'in' => 'query', 'required' => true, 'schema' => { 'type' => 'string', 'maxLength' => 10, 'pattern' => '^[A-Z]+$' }, }
@app = new_rack_app(schema: query_param_schema(parameter))

get '/events?query_string=%c0%af'

assert_equal 400, last_response.status
end

it 'validates query params declared with bracket notation names' do
check_parameter = lambda { |env|
assert_equal '/test', env['committee.query_hash']['filter[slug]']
Expand Down
Loading