Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1545 +/- ##
==========================================
+ Coverage 64.63% 64.69% +0.06%
==========================================
Files 69 69
Lines 6309 6317 +8
Branches 1399 1402 +3
==========================================
+ Hits 4078 4087 +9
+ Misses 2191 2190 -1
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR filters Web Speech API voices used by ReadAloud to hide known Apple novelty or low-quality voice families.
Changes:
- Adds
WebTTSEngine.isGoodVoice()to reject selected Apple voice URI prefixes. - Applies the filter in
getVoices(). - Adds a Jest test covering the new voice filtering behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/plugins/tts/WebTTSEngine.js |
Adds and applies voice filtering for Web TTS voices. |
tests/jest/plugins/tts/WebTTSEngine.test.js |
Adds coverage for filtering known Apple novelty voice prefixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
101
to
102
| const voices = speechSynthesis.getVoices().filter(WebTTSEngine.isGoodVoice); | ||
| if (voices.filter(v => v.default).length != 1) { |
…oices Co-Authored-By: Drini Cami <cdrini@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cdrini
force-pushed
the
feature/exclude-ios-joke-voices
branch
from
October 23, 2026 07:42
6a96b6b to
4e425f5
Compare
cdrini
marked this pull request as ready for review
October 23, 2026 07:45
Co-Authored-By: Drini Cami <cdrini@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA link:
Before:
Loads of novelty voices for things like "Bubbles", which play a bubbly sound. Funny, but not super helpful :P . Or very old low quality synthesized voices like "Grandma". Most user's won't want these, so disable them.
After: