Repository navigation
Don't build toolbar search when toolbar is hidden - #1616
Merged
cdrini merged 2 commits intoOct 23, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Avoids fetching icon_search_button.svg when showToolbar is false (internetarchive#1611) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1616 +/- ##
==========================================
+ Coverage 64.63% 64.65% +0.01%
==========================================
Files 69 69
Lines 6309 6309
Branches 1399 1400 +1
==========================================
+ Hits 4078 4079 +1
+ Misses 2191 2190 -1
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Automerging, small low risk fix. |
Contributor
Author
|
Note this only incidentally fixes #1611 . The root cause is that the images base URL config needs to be set on archive.org to the correct production value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1611. BookReader built the toolbar search form even with
showToolbar: false(as on archive.org), so the browser fetched its icon anyway. The 404 itself comes from a staleimagesBaseURLin@internetarchive/ia-music-player's liner-notes config, which needs a separate fix there.Technical
showToolbaris true.Testing
Open http://localhost:8000/details/goodytwoshoes00newyiala and check the Network tab: no request for
icon_search_button.svg. With?options.showToolbar=true, toolbar search still works.Screenshots/Videos
N/A, no visual change.
🤖 Generated with Claude Code