Repository navigation
Conversation
Co-Authored-By: Drini Cami <cdrini@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
- Coverage 64.65% 64.63% -0.02%
==========================================
Files 69 69
Lines 6309 6309
Branches 1400 1400
==========================================
- Hits 4079 4078 -1
- Misses 2190 2191 +1
Partials 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Translating to Korean, Japanese or Chinese often never shows any text. Their models are much larger (43–60 MB vs ~17 MB for e.g. French), and bergamot's default 60s per-file download timeout aborts them on slower connections; the spinner then reports the model as loaded, but nothing gets translated.
This sets
downloadTimeout: 0so the download isn't cut off.Technical
Independent of the download progress PR; the two merge cleanly.
Testing
On the IA demo with the translate experiment enabled, throttle the network (e.g. ~600 KB/s in devtools) and translate to Korean. Before: the model download fails after 60s (console: "Could not fetch … for en->ko model") and no text appears. After: the page translates once the download finishes (~2 min at that speed).
Screenshots/Videos
N/A
🤖 Generated with Claude Code