Skip to content

Fix translation to Korean/Japanese/Chinese timing out - #1618

Open
cdrini wants to merge 1 commit into
internetarchive:masterfrom
cdrini:translate-cjk-fix
Open

cdrini wants to merge 1 commit into
internetarchive:masterfrom
cdrini:translate-cjk-fix

Conversation

@cdrini

@cdrini cdrini commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Description

Translating to Korean, Japanese or Chinese often never shows any text. Their models are much larger (43–60 MB vs ~17 MB for e.g. French), and bergamot's default 60s per-file download timeout aborts them on slower connections; the spinner then reports the model as loaded, but nothing gets translated.

This sets downloadTimeout: 0 so the download isn't cut off.

Technical

Independent of the download progress PR; the two merge cleanly.

Testing

On the IA demo with the translate experiment enabled, throttle the network (e.g. ~600 KB/s in devtools) and translate to Korean. Before: the model download fails after 60s (console: "Could not fetch … for en->ko model") and no text appears. After: the page translates once the download finishes (~2 min at that speed).

Screenshots/Videos

N/A

🤖 Generated with Claude Code

Co-Authored-By: Drini Cami <cdrini@gmail.com>
@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.63%. Comparing base (042a0e4) to head (f4cb069).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
- Coverage   64.65%   64.63%   -0.02%     
==========================================
  Files          69       69              
  Lines        6309     6309              
  Branches     1400     1400              
==========================================
- Hits         4079     4078       -1     
- Misses       2190     2191       +1     
  Partials       40       40              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants