fix: standalone bundle + standardrb clean - #764
Open
ronaldtse wants to merge 3 commits into
Open
Conversation
GitHub rejects SARIF from advanced (workflow) configurations when default setup is enabled; default setup already scans every push.
- Gemfile: fall back to the published interscript-maps gem when no sibling ../maps checkout exists, so the repo bundles standalone (mirrors the existing secryst group pattern) - Clear all remaining standardrb offenses in lib/: mechanical corrections (chars, and/or precedence, paren-wrapped assignment), explicit directives for deliberate patterns (eval-based compiler, method_missing DSL, execution-context globals, debug hooks) - Verified zero behavior change: transliteration smoke test identical before/after
Bundler removed --with; it now fails every install step. Use 'bundle config set --local with jsexec' before bundle install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two intertwined blockers for standalone use of this repo:
The Gemfile hard-required a sibling ../maps checkout (path: dependency). Standalone clones and the StandardRB CI job (which does not bootstrap the monorepo) died in Bundler::PathError. Now it uses the sibling path when present, exactly like the existing secryst group pattern, and falls back to the published interscript-maps gem otherwise. The gemspec was already correct; only the dev Gemfile was broken.
The StandardRB job then surfaced 37 real offenses in lib/:
Verified: bundle exec standardrb exits 0; a transliteration smoke test over multiple maps is byte-identical before/after the change.