Repository navigation
fix: report failure when npm blocks install scripts - #35
Merged
Merged
Conversation
theproducer
requested review from
a team and
andredestro
and removed request for
a team
October 12, 2026 17:28
andredestro
approved these changes
Oct 23, 2026
andredestro
approved these changes
Oct 23, 2026
Co-authored-by: André Destro <254790+andredestro@users.noreply.github.com>
# Conflicts: # src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue on NPM 12 where the migration currently exits 0 when it blocks an install script. A plugin author sees an unqualified success when in reality the install scripts were skipped.
Now, the migrator will report which packages were blocked, and give instructions on how to unblock them to continue the migration.
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments